You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Quanlong Huang (Code Review)" <ge...@cloudera.org> on 2019/01/29 12:28:50 UTC
[Impala-ASF-CR] IMPALA-8135: Bump maven-surefire-plugin version to 2.20
Quanlong Huang has uploaded this change for review. ( http://gerrit.cloudera.org:8080/12295
Change subject: IMPALA-8135: Bump maven-surefire-plugin version to 2.20
......................................................................
IMPALA-8135: Bump maven-surefire-plugin version to 2.20
Bump maven-surefire-plugin version from 2.18 to 2.20 to support running
spercific methods in a parametized junit test class. Impala has some
parameterized JUnit test classes, e.g. AuthorizationTest. It supports
testing on file based authz policy and sentry based authz policy by
parameterizing the TestContext. With our current maven-surefire-plugin
version we can't run a single test method in such kind of classes.
This patch bumps maven-surefire-plugin version to 2.20 so we can run
spercific testMethod of a parameterized class like:
mvn test -Dtest=AuthorizationTest#TestShowTableResultsFiltered[0]
or
mvn test -Dtest=AuthorizationTest#TestShowTableResultsFiltered[*]
Test:
- run FE tests locally.
Change-Id: Ib1d85e181d1e9a15ab5b5d0d6744b6cbf7d5b5b8
---
M fe/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/12295/1
--
To view, visit http://gerrit.cloudera.org:8080/12295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ib1d85e181d1e9a15ab5b5d0d6744b6cbf7d5b5b8
Gerrit-Change-Number: 12295
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-8135: Bump maven-surefire-plugin version to 2.20
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12295 )
Change subject: IMPALA-8135: Bump maven-surefire-plugin version to 2.20
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/3683/ DRY_RUN=false
--
To view, visit http://gerrit.cloudera.org:8080/12295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1d85e181d1e9a15ab5b5d0d6744b6cbf7d5b5b8
Gerrit-Change-Number: 12295
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 29 Jan 2019 22:54:03 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8135: Bump maven-surefire-plugin version to 2.20
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12295 )
Change subject: IMPALA-8135: Bump maven-surefire-plugin version to 2.20
......................................................................
Patch Set 1: Code-Review+2
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12295/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12295/1//COMMIT_MSG@10
PS1, Line 10: spercific
typo
--
To view, visit http://gerrit.cloudera.org:8080/12295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1d85e181d1e9a15ab5b5d0d6744b6cbf7d5b5b8
Gerrit-Change-Number: 12295
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Jan 2019 16:23:03 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-8135: Bump maven-surefire-plugin version to 2.20
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Hello Bharath Vissapragada, Impala Public Jenkins,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/12295
to look at the new patch set (#2).
Change subject: IMPALA-8135: Bump maven-surefire-plugin version to 2.20
......................................................................
IMPALA-8135: Bump maven-surefire-plugin version to 2.20
Bump maven-surefire-plugin version from 2.18 to 2.20 to support running
specific methods in a parametized junit test class. Impala has some
parameterized JUnit test classes, e.g. AuthorizationTest. It supports
testing on file based authz policy and sentry based authz policy by
parameterizing the TestContext. With our current maven-surefire-plugin
version we can't run a single test method in such kind of classes.
This patch bumps maven-surefire-plugin version to 2.20 so we can run
spercific testMethod of a parameterized class like:
mvn test -Dtest=AuthorizationTest#TestShowTableResultsFiltered[0]
or
mvn test -Dtest=AuthorizationTest#TestShowTableResultsFiltered[*]
Test:
- run FE tests locally.
Change-Id: Ib1d85e181d1e9a15ab5b5d0d6744b6cbf7d5b5b8
---
M fe/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/95/12295/2
--
To view, visit http://gerrit.cloudera.org:8080/12295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ib1d85e181d1e9a15ab5b5d0d6744b6cbf7d5b5b8
Gerrit-Change-Number: 12295
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
[Impala-ASF-CR] IMPALA-8135: Bump maven-surefire-plugin version to 2.20
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12295 )
Change subject: IMPALA-8135: Bump maven-surefire-plugin version to 2.20
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/1915/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/12295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1d85e181d1e9a15ab5b5d0d6744b6cbf7d5b5b8
Gerrit-Change-Number: 12295
Gerrit-PatchSet: 1
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Comment-Date: Tue, 29 Jan 2019 22:21:43 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8135: Bump maven-surefire-plugin version to 2.20
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/12295 )
Change subject: IMPALA-8135: Bump maven-surefire-plugin version to 2.20
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/12295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1d85e181d1e9a15ab5b5d0d6744b6cbf7d5b5b8
Gerrit-Change-Number: 12295
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Wed, 30 Jan 2019 03:28:32 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8135: Bump maven-surefire-plugin version to 2.20
Posted by "Bharath Vissapragada (Code Review)" <ge...@cloudera.org>.
Bharath Vissapragada has posted comments on this change. ( http://gerrit.cloudera.org:8080/12295 )
Change subject: IMPALA-8135: Bump maven-surefire-plugin version to 2.20
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/12295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1d85e181d1e9a15ab5b5d0d6744b6cbf7d5b5b8
Gerrit-Change-Number: 12295
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 29 Jan 2019 22:53:21 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-8135: Bump maven-surefire-plugin version to 2.20
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/12295 )
Change subject: IMPALA-8135: Bump maven-surefire-plugin version to 2.20
......................................................................
IMPALA-8135: Bump maven-surefire-plugin version to 2.20
Bump maven-surefire-plugin version from 2.18 to 2.20 to support running
specific methods in a parametized junit test class. Impala has some
parameterized JUnit test classes, e.g. AuthorizationTest. It supports
testing on file based authz policy and sentry based authz policy by
parameterizing the TestContext. With our current maven-surefire-plugin
version we can't run a single test method in such kind of classes.
This patch bumps maven-surefire-plugin version to 2.20 so we can run
spercific testMethod of a parameterized class like:
mvn test -Dtest=AuthorizationTest#TestShowTableResultsFiltered[0]
or
mvn test -Dtest=AuthorizationTest#TestShowTableResultsFiltered[*]
Test:
- run FE tests locally.
Change-Id: Ib1d85e181d1e9a15ab5b5d0d6744b6cbf7d5b5b8
Reviewed-on: http://gerrit.cloudera.org:8080/12295
Reviewed-by: Bharath Vissapragada <bh...@cloudera.com>
Tested-by: Impala Public Jenkins <im...@cloudera.com>
---
M fe/pom.xml
1 file changed, 1 insertion(+), 1 deletion(-)
Approvals:
Bharath Vissapragada: Looks good to me, approved
Impala Public Jenkins: Verified
--
To view, visit http://gerrit.cloudera.org:8080/12295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ib1d85e181d1e9a15ab5b5d0d6744b6cbf7d5b5b8
Gerrit-Change-Number: 12295
Gerrit-PatchSet: 3
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
[Impala-ASF-CR] IMPALA-8135: Bump maven-surefire-plugin version to 2.20
Posted by "Quanlong Huang (Code Review)" <ge...@cloudera.org>.
Quanlong Huang has posted comments on this change. ( http://gerrit.cloudera.org:8080/12295 )
Change subject: IMPALA-8135: Bump maven-surefire-plugin version to 2.20
......................................................................
Patch Set 2:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/12295/1//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/12295/1//COMMIT_MSG@10
PS1, Line 10: specific
> typo
Done
--
To view, visit http://gerrit.cloudera.org:8080/12295
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ib1d85e181d1e9a15ab5b5d0d6744b6cbf7d5b5b8
Gerrit-Change-Number: 12295
Gerrit-PatchSet: 2
Gerrit-Owner: Quanlong Huang <hu...@gmail.com>
Gerrit-Reviewer: Bharath Vissapragada <bh...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Quanlong Huang <hu...@gmail.com>
Gerrit-Comment-Date: Tue, 29 Jan 2019 22:47:43 +0000
Gerrit-HasComments: Yes