You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@fineract.apache.org by GitBox <gi...@apache.org> on 2020/05/10 12:57:45 UTC

[GitHub] [fineract] vorburger commented on pull request #863: bump spring-security-oauth2

vorburger commented on pull request #863:
URL: https://github.com/apache/fineract/pull/863#issuecomment-626324299


   I'm slightly reluctant to "self merge" this PR, even though technically I'm hereby reviewing and approving a change made by Dependabot so with green Travis, we got 4-eyes on this - my 2 eyes, and 1 each from Travis and Dependabot.. :rofl: 
   
   I'm not clear about what test coverage with have for the OAuth support, but I suspect zilch, zero, nothing. Would anyone actually using Fineract's OAuth support be willing to test if things still work after this upgrade? And ideally contribute a real non-regression test for it for the future...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org