You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2022/04/29 03:10:25 UTC
[GitHub] [superset] ChunshengZhao opened a new issue, #19892: Bar Chart can not highlight item.
ChunshengZhao opened a new issue, #19892:
URL: https://github.com/apache/superset/issues/19892
Superset Version: 1.5
VISUALIZATION TYPE: Bar Chart
BTW: Time-series Bar Chart v2 is normal.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Bar Chart can not highlight item. [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas closed issue #19892: Bar Chart can not highlight item.
URL: https://github.com/apache/superset/issues/19892
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] Bar Chart can not highlight item. [superset]
Posted by "rusackas (via GitHub)" <gi...@apache.org>.
rusackas commented on issue #19892:
URL: https://github.com/apache/superset/issues/19892#issuecomment-1962055507
The NVD3 bar chart has already been migrated to the newer ECharts counterpart. Closing this as resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AkashBoora commented on issue #19892: Bar Chart can not highlight item.
Posted by "AkashBoora (via GitHub)" <gi...@apache.org>.
AkashBoora commented on issue #19892:
URL: https://github.com/apache/superset/issues/19892#issuecomment-1486217650
This issue is related to NVD3 package, the events of chart is handled in the NVD3 package. For some charts like cumulativeLineChart the highlight property is added to the returned series object, but for the charts like multiBarChart this property is not getting added. And the function which handles events in the NVD3 package is not returning the event, so we dont have access to the mousePositions which tells us the item which got focused.
I tried different way with the calssname, Actually the bar which is getting fouces have the class name name as 'hover'. So based on that i tried to get the series information. By adding following code am able to get the highlighted item in tool tip.
**Added code:**
**File Name**: ./superset-frontend/plugins/legacy-preset-chart-nvd3/src/utils.js
**Method Name**: generateCompareTooltipContent
const hoverElement = document.getElementsByClassName('hover')[0];
const parentElement = hoverElement.parentElement
.getAttribute('class')
.split('-')
.slice(-1);
d.series[parentElement].highlight = true;
Loom Video: https://www.loom.com/share/3ed6e28d62fe41328b6896d919c2c741
NVD3 package link: https://github.com/nvd3-community/nvd3/tree/gh-pages/src/models
Cumulative line chart: https://github.com/nvd3-community/nvd3/blob/gh-pages/src/models/cumulativeLineChart.js
MultiBarChart: https://github.com/nvd3-community/nvd3/blob/gh-pages/src/models/multiBarChart.js
So could you please tell me wether we can do like this or not, if not please tell me what we can do about this issue thanks!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org