You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@camel.apache.org by "ldrozdo (via GitHub)" <gi...@apache.org> on 2023/07/24 08:24:48 UTC
[GitHub] [camel-quarkus] ldrozdo opened a new pull request, #5116: Ref#4772 Introduce group testing for different jdbc db types
ldrozdo opened a new pull request, #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116
Fix #4772
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ldrozdo commented on pull request #5116: Ref#4772 Introduce group testing for different jdbc db types
Posted by "ldrozdo (via GitHub)" <gi...@apache.org>.
ldrozdo commented on PR #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116#issuecomment-1670826700
@jamesnetherton thank you, the profile helped.
@ppalaga thanks, I've fixed the dependencies.
About the deleting `integration-tests/jdbc`, I will create a task for it and I will make sure the deletion won't affect our jobs.
I have one (hopefully last) problem. The native tests were already passing, but now they've started to fail with:
`Caused by: com.github.dockerjava.api.exception.DockerClientException: Could not pull image: failed to register layer: ApplyLayer exit status 1 stdout: stderr: write /usr/lib/x86_64-linux-gnu/libLLVM-14.so.1: no space left on device`
Please, is there something I can do about it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ldrozdo commented on pull request #5116: Ref#4772 Introduce group testing for different jdbc db types
Posted by "ldrozdo (via GitHub)" <gi...@apache.org>.
ldrozdo commented on PR #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116#issuecomment-1651312539
> @jamesnetherton honestly, I'm not sure what is the right process. But our QE job for database certification already uses `integration-tests/jdbc`, so I would leave it like this at least for a while.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #5116: Ref#4772 Introduce group testing for different jdbc db types
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116#issuecomment-1670837283
> is there something I can do about it
I guess we're eating up a lot of disk space with all of the container images we pull....
I can create a separate PR to try and reclaim some space before the tests run.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ldrozdo commented on pull request #5116: Ref#4772 Introduce group testing for different jdbc db types
Posted by "ldrozdo (via GitHub)" <gi...@apache.org>.
ldrozdo commented on PR #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116#issuecomment-1664005107
Hi @zhfeng , can you please help me? I managed to fix the failing checks, I think failings in native tests are glitches because before, they were already succesfull... But alternative-platform tests are still failing: `Could not find a valid Docker environment. Please check configuration. Attempted configurations were:
NpipeSocketClientProviderStrategy: failed with exception InvalidConfigurationException (windows containers are currently not supported)As no valid configuration was found, execution cannot continue.` Is there something I can do to fix it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on pull request #5116: Ref#4772 Introduce group testing for different jdbc db types
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on PR #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116#issuecomment-1647471963
Thanks @ldrozdo for working on this issue. I just add some comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on a diff in pull request #5116: Ref#4772 Introduce group testing for different jdbc db types
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on code in PR #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116#discussion_r1284725826
##########
integration-test-groups/jdbc/h2/pom.xml:
##########
@@ -0,0 +1,284 @@
+<?xml version="1.0" encoding="UTF-8"?>
+<!--
+
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+
+-->
+<project xmlns="http://maven.apache.org/POM/4.0.0"
+ xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+ xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/xsd/maven-4.0.0.xsd">
+ <modelVersion>4.0.0</modelVersion>
+
+ <parent>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-build-parent-it</artifactId>
+ <version>3.0.0-SNAPSHOT</version>
+ <relativePath>../../../poms/build-parent-it/pom.xml</relativePath>
+ </parent>
+
+ <artifactId>camel-quarkus-integration-tests-jdbc-h2</artifactId>
+ <name>Camel Quarkus :: Integration Tests :: JDBC H2</name>
+ <description>Integration tests for JDBC - H2 Database</description>
+
+ <properties>
+ <cq.jdbcKind>h2</cq.jdbcKind>
+ </properties>
+
+ <dependencies>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-jdbc</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-log</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-timer</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>org.apache.camel.quarkus</groupId>
+ <artifactId>camel-quarkus-bean</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-resteasy</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-jdbc-db2</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-jdbc-h2</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-jdbc-mariadb</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-jdbc-mssql</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-jdbc-mysql</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-jdbc-oracle</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>io.quarkus</groupId>
+ <artifactId>quarkus-jdbc-postgresql</artifactId>
+ </dependency>
Review Comment:
Are all these JDBC artifacts needed in this specific test module? We generally prefer keeping the [minimal set of dependencies](https://camel.apache.org/camel-quarkus/latest/contributor-guide/extension-testing.html#_minimal_set_of_dependencies). The same issue seems to exist in other submodules of `integration-test-groups/jdbc`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #5116: Ref#4772 Introduce group testing for different jdbc db types
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116#issuecomment-1671141140
@ldrozdo if you rebase with the latest work from `main`, the disk space issue should hopefully be resolved.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #5116: Ref#4772 Introduce group testing for different jdbc db types
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116#issuecomment-1672622904
Follow up issue to remove the old itest module https://github.com/apache/camel-quarkus/issues/5164.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ldrozdo commented on a diff in pull request #5116: Ref#4772 Introduce group testing for different jdbc db types
Posted by "ldrozdo (via GitHub)" <gi...@apache.org>.
ldrozdo commented on code in PR #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116#discussion_r1274624587
##########
integration-test-groups/jdbc/db2/src/main/resources/application.properties:
##########
@@ -0,0 +1,44 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+#
+# Quarkus :: DS
+#
+quarkus.datasource.postgresql.db-kind=postgresql
+quarkus.datasource.postgresql.jdbc.max-size=8
+
+quarkus.datasource.mysql.db-kind=mysql
+quarkus.datasource.mysql.jdbc.max-size=8
+
+quarkus.datasource.mariadb.db-kind=mariadb
+quarkus.datasource.mariadb.jdbc.max-size=8
+
+quarkus.datasource.oracle.db-kind=oracle
+quarkus.datasource.oracle.jdbc.max-size=8
+
+quarkus.datasource.h2.db-kind=h2
+quarkus.datasource.h2.jdbc.max-size=8
+
+quarkus.datasource.db2.db-kind=db2
+quarkus.datasource.db2.jdbc.max-size=8
+
+quarkus.datasource.mssql.db-kind=mssql
+quarkus.datasource.mssql.jdbc.max-size=8
+
Review Comment:
@zhfeng I thought that the `application.properties` file should be the same for all modules, otherwise group tests don't work properly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton commented on pull request #5116: Ref#4772 Introduce group testing for different jdbc db types
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton commented on PR #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116#issuecomment-1664010927
> Is there something I can do to fix it?
There's no Docker on the Windows build. You can add a profile like this one so the test gets skipped on that platform:
https://github.com/apache/camel-quarkus/blob/main/integration-test-groups/azure/azure-storage-blob/pom.xml#L165-L175
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ldrozdo commented on a diff in pull request #5116: Ref#4772 Introduce group testing for different jdbc db types
Posted by "ldrozdo (via GitHub)" <gi...@apache.org>.
ldrozdo commented on code in PR #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116#discussion_r1274622742
##########
integration-test-groups/jdbc/db2/src/main/resources/reflection-config.json:
##########
Review Comment:
@zhfeng thanks, I added the annotations (note: there is no `BaseCamelJdbcTest` class, I forgot to delete it, so the annotation should be only on two classes)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] zhfeng commented on a diff in pull request #5116: Ref#4772 Introduce group testing for different jdbc db types
Posted by "zhfeng (via GitHub)" <gi...@apache.org>.
zhfeng commented on code in PR #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116#discussion_r1271928578
##########
integration-test-groups/jdbc/db2/src/main/resources/reflection-config.json:
##########
Review Comment:
I think we could avoid using `reflection-config.json` and how about adding `@RegisterForReflection` on these three classes?
##########
integration-test-groups/jdbc/db2/src/main/resources/application.properties:
##########
@@ -0,0 +1,44 @@
+## ---------------------------------------------------------------------------
+## Licensed to the Apache Software Foundation (ASF) under one or more
+## contributor license agreements. See the NOTICE file distributed with
+## this work for additional information regarding copyright ownership.
+## The ASF licenses this file to You under the Apache License, Version 2.0
+## (the "License"); you may not use this file except in compliance with
+## the License. You may obtain a copy of the License at
+##
+## http://www.apache.org/licenses/LICENSE-2.0
+##
+## Unless required by applicable law or agreed to in writing, software
+## distributed under the License is distributed on an "AS IS" BASIS,
+## WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+## See the License for the specific language governing permissions and
+## limitations under the License.
+## ---------------------------------------------------------------------------
+
+#
+# Quarkus :: DS
+#
+quarkus.datasource.postgresql.db-kind=postgresql
+quarkus.datasource.postgresql.jdbc.max-size=8
+
+quarkus.datasource.mysql.db-kind=mysql
+quarkus.datasource.mysql.jdbc.max-size=8
+
+quarkus.datasource.mariadb.db-kind=mariadb
+quarkus.datasource.mariadb.jdbc.max-size=8
+
+quarkus.datasource.oracle.db-kind=oracle
+quarkus.datasource.oracle.jdbc.max-size=8
+
+quarkus.datasource.h2.db-kind=h2
+quarkus.datasource.h2.jdbc.max-size=8
+
+quarkus.datasource.db2.db-kind=db2
+quarkus.datasource.db2.jdbc.max-size=8
+
+quarkus.datasource.mssql.db-kind=mssql
+quarkus.datasource.mssql.jdbc.max-size=8
+
Review Comment:
Can we only keep `quarkus.datasource.db2` configurations sine it is for `db2` testing?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] jamesnetherton merged pull request #5116: Ref#4772 Introduce group testing for different jdbc db types
Posted by "jamesnetherton (via GitHub)" <gi...@apache.org>.
jamesnetherton merged PR #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [camel-quarkus] ppalaga commented on pull request #5116: Ref#4772 Introduce group testing for different jdbc db types
Posted by "ppalaga (via GitHub)" <gi...@apache.org>.
ppalaga commented on PR #5116:
URL: https://github.com/apache/camel-quarkus/pull/5116#issuecomment-1666020371
> @jamesnetherton honestly, I'm not sure what is the right process. But our QE job for database certification already uses `integration-tests/jdbc`, so I would leave it like this at least for a while.
I guess, after merging this change, you want to run tests in all submodules of `integration-test-groups/jdbc`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@camel.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org