You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Alexander Rukletsov <al...@mesosphere.io> on 2015/01/30 16:36:07 UTC
Re: Review Request 29927: Removed unnecessary lifecycle method from
MasterAllocatorTest.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29927/
-----------------------------------------------------------
(Updated Jan. 30, 2015, 3:36 p.m.)
Review request for mesos, Bernd Mathiske and Niklas Nielsen.
Changes
-------
Address BenM's comments; rebased.
Summary (updated)
-----------------
Removed unnecessary lifecycle method from MasterAllocatorTest.
Bugs: MESOS-2213
https://issues.apache.org/jira/browse/MESOS-2213
Repository: mesos-git
Description (updated)
-------
Updated TestAllocator does not cause GMOCK warnings for unused method calls. Hence there is no need for stopping allocation explicitly.
Diffs (updated)
-----
src/tests/master_allocator_tests.cpp 018a6cc
Diff: https://reviews.apache.org/r/29927/diff/
Testing
-------
make check (Ubuntu, OS X)
Thanks,
Alexander Rukletsov
Re: Review Request 29927: Removed unnecessary lifecycle method from
MasterAllocatorTest.
Posted by Alexander Rukletsov <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29927/
-----------------------------------------------------------
(Updated Feb. 12, 2015, 7:39 p.m.)
Review request for mesos, Bernd Mathiske, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-2213
https://issues.apache.org/jira/browse/MESOS-2213
Repository: mesos
Description
-------
TestAllocator does not cause GMOCK warnings for unused method calls any more. Hence there is no need for stopping allocation explicitly.
Diffs (updated)
-----
src/tests/master_allocator_tests.cpp b16462571bc3760aedb0a86019d6627ded15ea49
Diff: https://reviews.apache.org/r/29927/diff/
Testing
-------
make check (Ubuntu, OS X)
Thanks,
Alexander Rukletsov
Re: Review Request 29927: Removed unnecessary lifecycle method from
MasterAllocatorTest.
Posted by Alexander Rukletsov <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29927/
-----------------------------------------------------------
(Updated Feb. 10, 2015, 8 p.m.)
Review request for mesos, Bernd Mathiske, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-2213
https://issues.apache.org/jira/browse/MESOS-2213
Repository: mesos
Description (updated)
-------
TestAllocator does not cause GMOCK warnings for unused method calls any more. Hence there is no need for stopping allocation explicitly.
Diffs (updated)
-----
src/tests/master_allocator_tests.cpp cad8024c9ae779e55e036c39ffa9165071a89a15
Diff: https://reviews.apache.org/r/29927/diff/
Testing
-------
make check (Ubuntu, OS X)
Thanks,
Alexander Rukletsov
Re: Review Request 29927: Removed unnecessary lifecycle method from
MasterAllocatorTest.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29927/#review71292
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On Feb. 4, 2015, 4:50 p.m., Alexander Rukletsov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/29927/
> -----------------------------------------------------------
>
> (Updated Feb. 4, 2015, 4:50 p.m.)
>
>
> Review request for mesos, Bernd Mathiske, Ben Mahler, Niklas Nielsen, and Vinod Kone.
>
>
> Bugs: MESOS-2213
> https://issues.apache.org/jira/browse/MESOS-2213
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Updated TestAllocator does not cause GMOCK warnings for unused method calls. Hence there is no need for stopping allocation explicitly.
>
>
> Diffs
> -----
>
> src/tests/master_allocator_tests.cpp 018a6cc
>
> Diff: https://reviews.apache.org/r/29927/diff/
>
>
> Testing
> -------
>
> make check (Ubuntu, OS X)
>
>
> Thanks,
>
> Alexander Rukletsov
>
>
Re: Review Request 29927: Removed unnecessary lifecycle method from
MasterAllocatorTest.
Posted by Alexander Rukletsov <al...@mesosphere.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/29927/
-----------------------------------------------------------
(Updated Feb. 4, 2015, 4:50 p.m.)
Review request for mesos, Bernd Mathiske, Ben Mahler, Niklas Nielsen, and Vinod Kone.
Changes
-------
Rebased.
Bugs: MESOS-2213
https://issues.apache.org/jira/browse/MESOS-2213
Repository: mesos
Description
-------
Updated TestAllocator does not cause GMOCK warnings for unused method calls. Hence there is no need for stopping allocation explicitly.
Diffs (updated)
-----
src/tests/master_allocator_tests.cpp 018a6cc
Diff: https://reviews.apache.org/r/29927/diff/
Testing
-------
make check (Ubuntu, OS X)
Thanks,
Alexander Rukletsov