You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2022/01/31 08:20:41 UTC

[GitHub] [pulsar] nicoloboschi opened a new pull request #14074: [java client] let the 'properties' to empty for ConsumerBuilder and ProducerBuilder

nicoloboschi opened a new pull request #14074:
URL: https://github.com/apache/pulsar/pull/14074


   
   Fixes #14072 
   
   ### Motivation
   
   When calling `ProducerBuilder#properties` and `ConsumerBuilder#properties` with an empty map the builder will throw a IAE
   There are some cases where you build an abstraction over the Consumer or Producer build process, and it's very annoying to check if the computed `Map` is empty or not. There are no pros to keep the checks
   
   ### Modifications
   
   * Let the properties field to be an empty `Map `for `ConsumerBuilder` and `ProducerBuilder`
   
   ### Verifying this change
   
   
   ### Documentation
   
   - [x] `no-need-doc` 
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi commented on pull request #14074: [java client] let the 'properties' to be empty for ConsumerBuilder and ProducerBuilder

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #14074:
URL: https://github.com/apache/pulsar/pull/14074#issuecomment-1025887776


   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] Shoothzj merged pull request #14074: [java client] let the 'properties' to be empty for ConsumerBuilder and ProducerBuilder

Posted by GitBox <gi...@apache.org>.
Shoothzj merged pull request #14074:
URL: https://github.com/apache/pulsar/pull/14074


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [pulsar] nicoloboschi commented on pull request #14074: [java client] let the 'properties' to be empty for ConsumerBuilder and ProducerBuilder

Posted by GitBox <gi...@apache.org>.
nicoloboschi commented on pull request #14074:
URL: https://github.com/apache/pulsar/pull/14074#issuecomment-1026883673


   /pulsarbot rerun-failure-checks


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org