You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2021/06/04 03:12:37 UTC

[GitHub] [commons-jexl] csamak opened a new pull request #56: Call Lock.lock before the try

csamak opened a new pull request #56:
URL: https://github.com/apache/commons-jexl/pull/56


   Probably not an issue with the ReentrantReadWriteLock implementation of
   Lock.
   Other lock usage in Introspector already calls lock before the try.
   
   See:
   https://docs.oracle.com/javase/8/docs/api/java/util/concurrent/locks/Lock.html
   https://errorprone.info/bugpattern/LockNotBeforeTry


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-jexl] coveralls commented on pull request #56: Call Lock.lock before the try

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #56:
URL: https://github.com/apache/commons-jexl/pull/56#issuecomment-854327337


   
   [![Coverage Status](https://coveralls.io/builds/40297415/badge)](https://coveralls.io/builds/40297415)
   
   Coverage remained the same at 86.764% when pulling **c45b35726534513d131069e00b07aa7e734629c3 on csamak:obtain-lock** into **3bbdc91d649a085564561a6e93ba9e052d841508 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-jexl] coveralls commented on pull request #56: Call Lock.lock before the try

Posted by GitBox <gi...@apache.org>.
coveralls commented on pull request #56:
URL: https://github.com/apache/commons-jexl/pull/56#issuecomment-854327337


   
   [![Coverage Status](https://coveralls.io/builds/40297415/badge)](https://coveralls.io/builds/40297415)
   
   Coverage remained the same at 86.764% when pulling **c45b35726534513d131069e00b07aa7e734629c3 on csamak:obtain-lock** into **3bbdc91d649a085564561a6e93ba9e052d841508 on apache:master**.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [commons-jexl] henrib merged pull request #56: Call Lock.lock before the try

Posted by GitBox <gi...@apache.org>.
henrib merged pull request #56:
URL: https://github.com/apache/commons-jexl/pull/56


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org