You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pulsar.apache.org by GitBox <gi...@apache.org> on 2019/07/03 02:07:52 UTC
[GitHub] [pulsar] jiazhai commented on a change in pull request #4653:
[issue 4589] Fix redelivered message logic of partition topic
jiazhai commented on a change in pull request #4653: [issue 4589] Fix redelivered message logic of partition topic
URL: https://github.com/apache/pulsar/pull/4653#discussion_r299751630
##########
File path: pulsar-client-cpp/lib/PartitionedConsumerImpl.cc
##########
@@ -365,6 +365,7 @@ void PartitionedConsumerImpl::messageReceived(Consumer consumer, const Message&
}
messages_.push(msg);
if (messageListener_) {
+ unAckedMessageTrackerPtr_->add(msg.getMessageId());
Review comment:
Thanks for the work. Seems this is only related with (messageListener_ != null), And not covered by the test case added.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services