[GitHub] [accumulo] milleruntime commented on a change in pull request #1027: Fix possible bug and improve errors in Tablet

[GitBox <gi...@apache.org>]

milleruntime commented on a change in pull request #1027: Fix possible bug and improve errors in Tablet
URL: https://github.com/apache/accumulo/pull/1027#discussion_r264905403
 
 

 ##########
 File path: server/tserver/src/main/java/org/apache/accumulo/tserver/tablet/Tablet.java
 ##########
 @@ -2407,14 +2413,11 @@ public void importMapFiles(long tid, Map<FileRef,MapFileInfo> fileMap, boolean s
         return;
       }
 
-      if (writesInProgress < 0) {
-        throw new IllegalStateException("writesInProgress < 0 " + writesInProgress);
-      }
-
-      writesInProgress++;
+      incrementWritesInProgress(Optional.empty());
     }
-    tabletServer.updateBulkImportState(files, BulkImportState.LOADING);
     try {
+      tabletServer.updateBulkImportState(files, BulkImportState.LOADING);
+
 
 Review comment:
   Here was the fix to the potential bug... moving this into the try. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services