You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2023/01/12 19:53:35 UTC
[GitHub] [superset] aehanno opened a new issue, #22705: SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
aehanno opened a new issue, #22705:
URL: https://github.com/apache/superset/issues/22705
I get this error for display filter tab
`SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.`
when I display my embedded dashboard in chrome's private mode
#### How to reproduce the bug
1. Go to your private mode
2. Access to your embedded dashboard
### Expected results
Dashboard is well display
### Actual results
Error in filter tab : `SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.`
#### Screenshots
### Environment
(please complete the following information):
- browser type and version: chrome
- superset version: `2.0.1`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] treygilliland commented on issue #22705: SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
Posted by GitBox <gi...@apache.org>.
treygilliland commented on issue #22705:
URL: https://github.com/apache/superset/issues/22705#issuecomment-1380946254
Providing some screenshots of what the error on the embedded iFrame shows:
<img width="619" alt="Screen Shot 2023-01-12 at 3 12 21 PM" src="https://user-images.githubusercontent.com/28707707/212170991-4915dd7d-aab3-4a0b-bbe4-25f21520e2e9.png">
<img width="868" alt="Screen Shot 2023-01-12 at 3 12 07 PM" src="https://user-images.githubusercontent.com/28707707/212170994-b9ebced0-2386-4e2d-97c5-ed7b35fa9556.png">
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on issue #22705: SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
Posted by GitBox <gi...@apache.org>.
aehanno commented on issue #22705:
URL: https://github.com/apache/superset/issues/22705#issuecomment-1384148252
Hi @AAfghahi, Will the fix also be in version 2.1.0?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
Re: [I] SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document. [superset]
Posted by "frassinier (via GitHub)" <gi...@apache.org>.
frassinier commented on issue #22705:
URL: https://github.com/apache/superset/issues/22705#issuecomment-1756318268
Again a PR is needed for the same reasons. 🫣
https://github.com/apache/superset/pull/25599
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] rusackas commented on issue #22705: SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
Posted by GitBox <gi...@apache.org>.
rusackas commented on issue #22705:
URL: https://github.com/apache/superset/issues/22705#issuecomment-1382512539
Pinging @lilykuang as a defacto embedded expert, and pinging @AAfghahi since this seems to be a 2.0.1 issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] treygilliland commented on issue #22705: SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
Posted by GitBox <gi...@apache.org>.
treygilliland commented on issue #22705:
URL: https://github.com/apache/superset/issues/22705#issuecomment-1382612704
> @treygilliland to clarify, have you used 2.0.0 under same conditions and not had this error, or did you skip 2.0.0 and have only used 2.0.1 and are coming from 1.5.x version prior to this?
I am currently using Embedded Superset on a `latest` docker image from a few months ago and don't have this issue. The reason for migrating to 2.0.1 is so we can pin our instance to a version. I haven't tested 2.0.0 so the issue likely exists there if the fix you mentioned earlier wasn't present there.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on issue #22705: SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on issue #22705:
URL: https://github.com/apache/superset/issues/22705#issuecomment-1382557355
thank you @rusackas we're going ot be making a minor 2.0.2 release and we will put this on the docket
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] eric-briscoe commented on issue #22705: SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
Posted by GitBox <gi...@apache.org>.
eric-briscoe commented on issue #22705:
URL: https://github.com/apache/superset/issues/22705#issuecomment-1382592945
I believe this issue was introduced by this PR: https://github.com/apache/superset/pull/18576/files#diff-0cf142796bd16ac5769ddcb30d41eda23c36ca61176dba4521e2125bd87da01c that adds use of window.sessionStorage in a new file. This PR merged to master branch about 11 months ago, but would not have showed up in a release until 2.0.0 and 2.0.1.
This PR fixes the same error reported here and was merged to master ~5 month ago: https://github.com/apache/superset/pull/21157/files which I do not think made it into 2.0.0 or 2.0.1.
@treygilliland to clarify, have you used 2.0.0 under same conditions and not had this error, or did you skip 2.0.0 and have only used 2.0.1 and are coming from 1.5.x version prior to this?
For more context, most browsers disable access to localStorage and sessionStorage when running in incognito / private modes. The PR that fixes the runtime error added a safety check to ensure window.localStorage and window.sessionStorage are available before calling them.
@AAfghahi @eschutho we should tag https://github.com/apache/superset/pull/21157/files with a 2.0 label so we can chery it in as the fix for this.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno closed issue #22705: SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
Posted by "aehanno (via GitHub)" <gi...@apache.org>.
aehanno closed issue #22705: SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
URL: https://github.com/apache/superset/issues/22705
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] AAfghahi commented on issue #22705: SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
Posted by GitBox <gi...@apache.org>.
AAfghahi commented on issue #22705:
URL: https://github.com/apache/superset/issues/22705#issuecomment-1387119837
@aehanno yes we will tag it and include it in the next release!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] treygilliland commented on issue #22705: SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
Posted by GitBox <gi...@apache.org>.
treygilliland commented on issue #22705:
URL: https://github.com/apache/superset/issues/22705#issuecomment-1386467607
@eric-briscoe Just wanted to confirm that patching https://github.com/apache/superset/pull/21157/files onto 2.0.1 fixes the issue. Thank you for pointing this out! Would love to see this in 2.0.2
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] treygilliland commented on issue #22705: SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
Posted by GitBox <gi...@apache.org>.
treygilliland commented on issue #22705:
URL: https://github.com/apache/superset/issues/22705#issuecomment-1380935187
I am having the same issue on Superset version 2.0.1, haven't seen this with previous versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] aehanno commented on issue #22705: SecurityError: Failed to read the 'sessionStorage' property from 'Window': Access is denied for this document.
Posted by "aehanno (via GitHub)" <gi...@apache.org>.
aehanno commented on issue #22705:
URL: https://github.com/apache/superset/issues/22705#issuecomment-1464082321
Correction in 2.0.1
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org