[GitHub] [doris] gavinchou commented on a diff in pull request #18510: [bug](be) fix accept null predicate mem leak

["gavinchou (via GitHub)" <gi...@apache.org>]

gavinchou commented on code in PR #18510:
URL: https://github.com/apache/doris/pull/18510#discussion_r1161660442


##########
be/src/olap/accept_null_predicate.h:
##########
@@ -60,7 +60,8 @@ class AcceptNullPredicate : public ColumnPredicate {
                       bool* flags) const override {
         if (column.has_null()) {
             // copy original flags
-            bool* original_flags = new bool[size];
+            auto original_flags_buf = std::make_unique<bool>(size);

Review Comment:
   Should it be `std::make_unique<bool[]>(size)`?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org