You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Grant Henke (Code Review)" <ge...@cloudera.org> on 2020/10/01 14:33:11 UTC

[kudu-CR] [util] info on sent/received if Blocking{Recv,Write} timed out

Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/16475 )

Change subject: [util] info on sent/received if Blocking{Recv,Write} timed out
......................................................................


Patch Set 1: Code-Review+1

(1 comment)

http://gerrit.cloudera.org:8080/#/c/16475/1/src/kudu/util/net/socket.cc
File src/kudu/util/net/socket.cc:

http://gerrit.cloudera.org:8080/#/c/16475/1/src/kudu/util/net/socket.cc@469
PS1, Line 469:       return Status::TimedOut(Substitute("sent $0 of $1 requested bytes",
nit: Should the messages still indicate there was a timeout even though the status is TimedOut?



-- 
To view, visit http://gerrit.cloudera.org:8080/16475
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I5d0b910a93d8b3c8c4b387f73c19207021d56574
Gerrit-Change-Number: 16475
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Bankim Bhavsar <ba...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Comment-Date: Thu, 01 Oct 2020 14:33:11 +0000
Gerrit-HasComments: Yes