You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@beam.apache.org by dh...@apache.org on 2017/01/24 20:27:42 UTC

[2/4] beam git commit: [BEAM-1302] BigQueryServicesImpl: skip logging warning if exceptions do not need retry.

[BEAM-1302] BigQueryServicesImpl: skip logging warning if exceptions do not need retry.


Project: http://git-wip-us.apache.org/repos/asf/beam/repo
Commit: http://git-wip-us.apache.org/repos/asf/beam/commit/2a23e8b5
Tree: http://git-wip-us.apache.org/repos/asf/beam/tree/2a23e8b5
Diff: http://git-wip-us.apache.org/repos/asf/beam/diff/2a23e8b5

Branch: refs/heads/master
Commit: 2a23e8b5dd11c825dfe13f79d69c2099069be724
Parents: 5b6dd91
Author: Pei He <pe...@google.com>
Authored: Mon Jan 23 17:39:20 2017 -0800
Committer: Dan Halperin <dh...@google.com>
Committed: Tue Jan 24 12:25:22 2017 -0800

----------------------------------------------------------------------
 .../org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java  | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/beam/blob/2a23e8b5/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
----------------------------------------------------------------------
diff --git a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
index 2098148..c9edf7c 100644
--- a/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
+++ b/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/bigquery/BigQueryServicesImpl.java
@@ -887,11 +887,11 @@ class BigQueryServicesImpl implements BigQueryServices {
       try {
         return request.execute();
       } catch (IOException e) {
-        LOG.warn("Ignore the error and retry the request.", e);
         lastException = e;
         if (!shouldRetry.apply(e)) {
           break;
         }
+        LOG.warn("Ignore the error and retry the request.", e);
       }
     } while (nextBackOff(sleeper, backoff));
     throw new IOException(