You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mina.apache.org by "Emmanuel Lecharny (JIRA)" <ji...@apache.org> on 2008/10/24 14:35:44 UTC
[jira] Resolved: (DIRMINA-626) Compilation Error in
org.apache.mina.transport.serial.DefaultSerialSessionConfig
[ https://issues.apache.org/jira/browse/DIRMINA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Emmanuel Lecharny resolved DIRMINA-626.
---------------------------------------
Resolution: Fixed
atm, I just removed the @override annotations. I don't think they are useful, but if so, we can improve the code as suiggested.
> Compilation Error in org.apache.mina.transport.serial.DefaultSerialSessionConfig
> --------------------------------------------------------------------------------
>
> Key: DIRMINA-626
> URL: https://issues.apache.org/jira/browse/DIRMINA-626
> Project: MINA
> Issue Type: Bug
> Components: Transport
> Affects Versions: 2.0.0-M4, 2.0.0-RC1
> Reporter: Edwin Lee
> Priority: Blocker
> Fix For: 2.0.0-M4, 2.0.0-RC1
>
> Attachments: AbstractSerialSessionConfig.java, DefaultSerialSessionConfig.java
>
>
> The public accessor/mutator methods in org.apache.mina.transport.serial.DefaultSerialSessionConfig are annotated with @Override, but its superclass (org.apache.mina.core.session.AbstractIoSessionConfig) does not have those methods declared.
> Propose to:
> 1. Add a new abstract class org.apache.mina.transport.serial.AbstractSerialSessionConfig which extends org.apache.mina.core.session.AbstractIoSessionConfig and implements org.apache.mina.transport.serial.SerialSessionConfig.
> 2. The new abstract class declares the methods which org.apache.mina.transport.serial.DefaultSerialSessionConfig @OverrideS.
> 3. org.apache.mina.transport.serial.DefaultSerialSessionConfig extends org.apache.mina.transport.serial.AbstractSerialSessionConfig instead.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
Re: [jira] Resolved: (DIRMINA-626) Compilation Error in org.apache.mina.transport.serial.DefaultSerialSessionConfig
Posted by Edwin Lee <ed...@yahoo.com.sg>.
Ah i see...
i just realised that i have been using 1.5 to compile (in Eclipse). Strange. My
workspace default have been set to 1.6 actually, but when i checked out the
Maven project, it set the environment to 1.5 instead (which i also have).
Regards,
Edwin
--- Emmanuel Lecharny <el...@gmail.com> wrote:
> Edwin Lee wrote:
> > Thanks Emmanuel,
> >
> > it compiles alright now.
> >
> FYI, this was pretty nasty : the @override annotation does not work the
> same way with JVM 1.5 and 1.6 versions. 1.6 jvms consider that this
> annotation can _also_ be used to describe methods that are not only
> present in one of the parent classes, but also accept those methods
> present in one of the implemented interface. 1.5 does not accept that,
> leading the compiler to blow chunks...
>
> It's now fixed, the fastest way : no more painfull annotations ;)
>
> PS: I forgot to thanks Sun for the JVM API stability ... :/
>
> --
> --
> cordialement, regards,
> Emmanuel Lécharny
> www.iktek.com
> directory.apache.org
Get your preferred Email name!
Now you can @ymail.com and @rocketmail.com
http://mail.promotions.yahoo.com/newdomains/sg/
Re: [jira] Resolved: (DIRMINA-626) Compilation Error in org.apache.mina.transport.serial.DefaultSerialSessionConfig
Posted by Emmanuel Lecharny <el...@gmail.com>.
Edwin Lee wrote:
> Thanks Emmanuel,
>
> it compiles alright now.
>
FYI, this was pretty nasty : the @override annotation does not work the
same way with JVM 1.5 and 1.6 versions. 1.6 jvms consider that this
annotation can _also_ be used to describe methods that are not only
present in one of the parent classes, but also accept those methods
present in one of the implemented interface. 1.5 does not accept that,
leading the compiler to blow chunks...
It's now fixed, the fastest way : no more painfull annotations ;)
PS: I forgot to thanks Sun for the JVM API stability ... :/
--
--
cordialement, regards,
Emmanuel Lécharny
www.iktek.com
directory.apache.org
Re: [jira] Resolved: (DIRMINA-626) Compilation Error in org.apache.mina.transport.serial.DefaultSerialSessionConfig
Posted by Edwin Lee <ed...@yahoo.com.sg>.
Thanks Emmanuel,
it compiles alright now.
Regards,
Edwin
--- "Emmanuel Lecharny (JIRA)" <ji...@apache.org> wrote:
>
> [
>
https://issues.apache.org/jira/browse/DIRMINA-626?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
> ]
>
> Emmanuel Lecharny resolved DIRMINA-626.
> ---------------------------------------
>
> Resolution: Fixed
>
> atm, I just removed the @override annotations. I don't think they are useful,
> but if so, we can improve the code as suiggested.
>
> > Compilation Error in
> org.apache.mina.transport.serial.DefaultSerialSessionConfig
> >
>
--------------------------------------------------------------------------------
> >
> > Key: DIRMINA-626
> > URL: https://issues.apache.org/jira/browse/DIRMINA-626
> > Project: MINA
> > Issue Type: Bug
> > Components: Transport
> > Affects Versions: 2.0.0-M4, 2.0.0-RC1
> > Reporter: Edwin Lee
> > Priority: Blocker
> > Fix For: 2.0.0-M4, 2.0.0-RC1
> >
> > Attachments: AbstractSerialSessionConfig.java,
> DefaultSerialSessionConfig.java
> >
> >
> > The public accessor/mutator methods in
> org.apache.mina.transport.serial.DefaultSerialSessionConfig are annotated
> with @Override, but its superclass
> (org.apache.mina.core.session.AbstractIoSessionConfig) does not have those
> methods declared.
> > Propose to:
> > 1. Add a new abstract class
> org.apache.mina.transport.serial.AbstractSerialSessionConfig which extends
> org.apache.mina.core.session.AbstractIoSessionConfig and implements
> org.apache.mina.transport.serial.SerialSessionConfig.
> > 2. The new abstract class declares the methods which
> org.apache.mina.transport.serial.DefaultSerialSessionConfig @OverrideS.
> > 3. org.apache.mina.transport.serial.DefaultSerialSessionConfig extends
> org.apache.mina.transport.serial.AbstractSerialSessionConfig instead.
>
> --
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>
>
Get your new Email address!
Grab the Email name you've always wanted before someone else does!
http://mail.promotions.yahoo.com/newdomains/sg/