You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@solr.apache.org by GitBox <gi...@apache.org> on 2021/03/15 14:20:43 UTC

[GitHub] [solr] NazerkeBS commented on a change in pull request #17: SOLR-14341: Move configName into DocCollection class

NazerkeBS commented on a change in pull request #17:
URL: https://github.com/apache/solr/pull/17#discussion_r594376813



##########
File path: solr/core/src/java/org/apache/solr/cloud/api/collections/CreateCollectionCmd.java
##########
@@ -374,7 +376,7 @@ public void call(ClusterState clusterState, ZkNodeProps message, @SuppressWarnin
         log.debug("Finished create command on all shards for collection: {}", collectionName);
         // Emit a warning about production use of data driven functionality
         boolean defaultConfigSetUsed = message.getStr(COLL_CONF) == null ||
-            message.getStr(COLL_CONF).equals(DEFAULT_CONFIGSET_NAME);
+            message.getStr(COLL_CONF).contains(DEFAULT_CONFIGSET_NAME);

Review comment:
       changed to `contains` as configName can be `_default.AUTOCREATED`




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org