You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2023/01/05 08:25:56 UTC
[GitHub] [nuttx] xiaoxiang781216 opened a new pull request, #8028: mm/map: Remove the unnessary map.h inclusion in various drivers
xiaoxiang781216 opened a new pull request, #8028:
URL: https://github.com/apache/nuttx/pull/8028
## Summary
and Fix include/nuttx/mm/map.h:55:28: error: 'struct task_group_s' declared inside parameter list will not be visible outside of this definition or declaration
## Impact
Fix build break
## Testing
Pass CI
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] xiaoxiang781216 commented on pull request #8028: mm/map: Remove the unnessary map.h inclusion in various drivers
Posted by GitBox <gi...@apache.org>.
xiaoxiang781216 commented on PR #8028:
URL: https://github.com/apache/nuttx/pull/8028#issuecomment-1371920639
@jlaitine our internal build server found some issue with https://github.com/apache/nuttx/pull/8021.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] pkarashchenko merged pull request #8028: mm/map: Remove the unnessary map.h inclusion in various drivers
Posted by GitBox <gi...@apache.org>.
pkarashchenko merged PR #8028:
URL: https://github.com/apache/nuttx/pull/8028
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] jlaitine commented on pull request #8028: mm/map: Remove the unnessary map.h inclusion in various drivers
Posted by GitBox <gi...@apache.org>.
jlaitine commented on PR #8028:
URL: https://github.com/apache/nuttx/pull/8028#issuecomment-1371971400
> @jlaitine our internal build server found some issue with #8021. Please take a look.
What is the error exactly?
The struct task_group_s needs to be forward declared in map.h. map.h is included in fs.h, but not every driver using map.h uses fs.h
you'll end up in circular dependencies between fs.h <-> sched.h <-> map.h, because sched.h includes fs.h.
I think I did this properly by forward declaring struct task_group_s in map.h, and included map.h in places where the mm_map is used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nuttx] jlaitine commented on pull request #8028: mm/map: Remove the unnessary map.h inclusion in various drivers
Posted by GitBox <gi...@apache.org>.
jlaitine commented on PR #8028:
URL: https://github.com/apache/nuttx/pull/8028#issuecomment-1371979282
> > @jlaitine our internal build server found some issue with #8021. Please take a look.
>
> What is the error exactly?
Ah got it. This PR was a fix for exactly that + removing some extra include!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org