You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Dan Smith <ds...@pivotal.io> on 2015/09/01 22:36:48 UTC
Review Request 38015: GEODE-295 - Expecting a suspect string in
BridgeMembershipDUnitTet
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38015/
-----------------------------------------------------------
Review request for geode and Darrel Schneider.
Repository: geode
Description
-------
testBridgeMembershipEventsInClient already had some code to expect the
suspect string, but it was writing to a weirdly constructed logger, so I
think it was not actually taking effect.
Diffs
-----
gemfire-core/src/test/java/com/gemstone/gemfire/cache30/BridgeMembershipDUnitTest.java 7f6af30740bccdb58762c8096ed83bcfd3293c22
Diff: https://reviews.apache.org/r/38015/diff/
Testing
-------
Thanks,
Dan Smith
Re: Review Request 38015: GEODE-295 - Expecting a suspect string in BridgeMembershipDUnitTet
Posted by Sudhir Menon <sm...@pivotal.io>.
+1
On Tue, Sep 1, 2015 at 1:52 PM, Darrel Schneider <ds...@pivotal.io>
wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38015/#review97334
> -----------------------------------------------------------
>
> Ship it!
>
>
> Ship It!
>
> - Darrel Schneider
>
>
> On Sept. 1, 2015, 1:36 p.m., Dan Smith wrote:
> >
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > https://reviews.apache.org/r/38015/
> > -----------------------------------------------------------
> >
> > (Updated Sept. 1, 2015, 1:36 p.m.)
> >
> >
> > Review request for geode and Darrel Schneider.
> >
> >
> > Repository: geode
> >
> >
> > Description
> > -------
> >
> > testBridgeMembershipEventsInClient already had some code to expect the
> > suspect string, but it was writing to a weirdly constructed logger, so I
> > think it was not actually taking effect.
> >
> >
> > Diffs
> > -----
> >
> >
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/BridgeMembershipDUnitTest.java
> 7f6af30740bccdb58762c8096ed83bcfd3293c22
> >
> > Diff: https://reviews.apache.org/r/38015/diff/
> >
> >
> > Testing
> > -------
> >
> >
> > Thanks,
> >
> > Dan Smith
> >
> >
>
>
--
Suds Menon
Head of Products (Real Time & Big Data)
503-724-1481 (c)
For
prompt responses to questions
on GemFire/SQLFire, please write to
rtds-dev-ea at gopivotal dot com
Re: Review Request 38015: GEODE-295 - Expecting a suspect string in
BridgeMembershipDUnitTet
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38015/#review97334
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Sept. 1, 2015, 1:36 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38015/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 1:36 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> testBridgeMembershipEventsInClient already had some code to expect the
> suspect string, but it was writing to a weirdly constructed logger, so I
> think it was not actually taking effect.
>
>
> Diffs
> -----
>
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/BridgeMembershipDUnitTest.java 7f6af30740bccdb58762c8096ed83bcfd3293c22
>
> Diff: https://reviews.apache.org/r/38015/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>
Re: Review Request 38015: GEODE-295 - Expecting a suspect string in
BridgeMembershipDUnitTet
Posted by Kirk Lund <ki...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/38015/#review97332
-----------------------------------------------------------
Ship it!
Ship It!
- Kirk Lund
On Sept. 1, 2015, 8:36 p.m., Dan Smith wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/38015/
> -----------------------------------------------------------
>
> (Updated Sept. 1, 2015, 8:36 p.m.)
>
>
> Review request for geode and Darrel Schneider.
>
>
> Repository: geode
>
>
> Description
> -------
>
> testBridgeMembershipEventsInClient already had some code to expect the
> suspect string, but it was writing to a weirdly constructed logger, so I
> think it was not actually taking effect.
>
>
> Diffs
> -----
>
> gemfire-core/src/test/java/com/gemstone/gemfire/cache30/BridgeMembershipDUnitTest.java 7f6af30740bccdb58762c8096ed83bcfd3293c22
>
> Diff: https://reviews.apache.org/r/38015/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dan Smith
>
>