You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Max Bowsher <ma...@ukf.net> on 2003/05/26 11:13:16 UTC
[Patch] Add missing dependencies in build.conf
There are two dependencies that are not declared in build.conf.
Max.
* build.conf (libsvn_ra_dav): Add libsvn_delta dependency.
(libsvn_ra_svn): Ditto.
Index: build.conf
===================================================================
--- build.conf (revision 6047)
+++ build.conf (working copy)
@@ -143,7 +143,7 @@
type = lib
path = subversion/libsvn_ra_dav
install = dav-lib
-libs = libsvn_subr $(SVN_APRUTIL_LIBS) $(SVN_APR_LIBS) $(NEON_LIBS)
+libs = libsvn_delta libsvn_subr $(SVN_APRUTIL_LIBS) $(SVN_APR_LIBS)
$(NEON_LIBS)
custom = ra-module
# Accessing repositories via SVN
@@ -151,7 +151,7 @@
type = lib
path = subversion/libsvn_ra_svn
install = base-lib
-libs = libsvn_subr $(SVN_APRUTIL_LIBS) $(SVN_APR_LIBS)
+libs = libsvn_delta libsvn_subr $(SVN_APRUTIL_LIBS) $(SVN_APR_LIBS)
custom = ra-module
# Accessing repositories via direct libsvn_fs
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Patch] Add missing dependencies in build.conf
Posted by cm...@collab.net.
"Max Bowsher" <ma...@ukf.net> writes:
> There are two dependencies that are not declared in build.conf.
Committed in revision 6064. Thanks for the patch.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Patch] Add missing dependencies in build.conf
Posted by Max Bowsher <ma...@ukf.net>.
Ben Collins-Sussman wrote:
> I don't understand why you need to do this. Dozens and dozens of
> people have been building subversion for more than a year, and we've
> never had to define this dependency before. What makes your system
> different?
I'm using Cygwin, and building libsvn_* as DLLs.
This dependency does not need to be declared if building libsvn_* as static
libs, because they can contain undefined references, provided they are
satisfied when the library is linked into a program. I skimmed through
build.conf, and it seems that every user of libsvn_ra_svn is also explicitly
using libsvn_ra_delta, expaining why the static build succeeded.
However, Windows DLLs cannot contain undefined references, hence
libsvn_ra_svn.la needs libsvn_ra_delta.la on the link command line.
(Ditto for libsvn_ra_dav)
IIRC unix shared libs do permit undefined references, explaining why this
has not been a problem on other platforms.
> Was this determined?
I don't understand. *How* was this determined?
The build failed with undefined references, so I added correct library to
satisfy those references to the link line.
Also verified by examining the import table of the produced DLLs, and again
by grepping the libsvn_ra_{svn,dav} source for functions beginning
svn_delta_ and svn_txdelta_. The relevant functions are (for both
libsvn_ra_svn and _dav):
svn_delta_default_editor
svn_txdelta_parse_svndiff
svn_txdelta_to_svndiff
Max.
> "Max Bowsher" <ma...@ukf.net> writes:
>
>> There are two dependencies that are not declared in build.conf.
>>
>> Max.
>>
>>
>> * build.conf (libsvn_ra_dav): Add libsvn_delta dependency.
>> (libsvn_ra_svn): Ditto.
>>
>> Index: build.conf
>> ===================================================================
>> --- build.conf (revision 6047)
>> +++ build.conf (working copy)
>> @@ -143,7 +143,7 @@
>> type = lib
>> path = subversion/libsvn_ra_dav
>> install = dav-lib
>> -libs = libsvn_subr $(SVN_APRUTIL_LIBS) $(SVN_APR_LIBS) $(NEON_LIBS)
>> +libs = libsvn_delta libsvn_subr $(SVN_APRUTIL_LIBS) $(SVN_APR_LIBS)
>> $(NEON_LIBS)
>> custom = ra-module
>>
>> # Accessing repositories via SVN
>> @@ -151,7 +151,7 @@
>> type = lib
>> path = subversion/libsvn_ra_svn
>> install = base-lib
>> -libs = libsvn_subr $(SVN_APRUTIL_LIBS) $(SVN_APR_LIBS)
>> +libs = libsvn_delta libsvn_subr $(SVN_APRUTIL_LIBS) $(SVN_APR_LIBS)
>> custom = ra-module
>>
>> # Accessing repositories via direct libsvn_fs
>>
>>
>> ---------------------------------------------------------------------
>> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
>> For additional commands, e-mail: dev-help@subversion.tigris.org
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Patch] Add missing dependencies in build.conf
Posted by Greg Stein <gs...@lyra.org>.
On Tue, May 27, 2003 at 09:14:27AM -0500, cmpilato@collab.net wrote:
> Ben Collins-Sussman <su...@collab.net> writes:
>
> > I don't understand why you need to do this. Dozens and dozens of
> > people have been building subversion for more than a year, and we've
> > never had to define this dependency before. What makes your system
> > different? Was this determined?
>
> Regardless of the fact that dozens and dozens of people have been
> building subversion, I believe this patch is correct. Those libraries
> *do* depend on code in libsvn_delta, so our build system should
> specify as much, even if that fact doesn't change a single thing in
> the day-to-day builds of 99% of the populace.
Absolutely agreed. The Mikey Man is right here. In the Unix space, the
symbols happend to resolve because the process already has those symbols
loaded into its namespace. But that doesn't mean that the libraries should
be negligent and not state the other libraries they depend upon.
[ Mike commited the patch ]
Goodness. Post-commit +1 from me.
Cheers,
-g
--
Greg Stein, http://www.lyra.org/
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Patch] Add missing dependencies in build.conf
Posted by cm...@collab.net.
Ben Collins-Sussman <su...@collab.net> writes:
> I don't understand why you need to do this. Dozens and dozens of
> people have been building subversion for more than a year, and we've
> never had to define this dependency before. What makes your system
> different? Was this determined?
Regardless of the fact that dozens and dozens of people have been
building subversion, I believe this patch is correct. Those libraries
*do* depend on code in libsvn_delta, so our build system should
specify as much, even if that fact doesn't change a single thing in
the day-to-day builds of 99% of the populace.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org
Re: [Patch] Add missing dependencies in build.conf
Posted by Ben Collins-Sussman <su...@collab.net>.
I don't understand why you need to do this. Dozens and dozens of
people have been building subversion for more than a year, and we've
never had to define this dependency before. What makes your system
different? Was this determined?
"Max Bowsher" <ma...@ukf.net> writes:
> There are two dependencies that are not declared in build.conf.
>
> Max.
>
>
> * build.conf (libsvn_ra_dav): Add libsvn_delta dependency.
> (libsvn_ra_svn): Ditto.
>
> Index: build.conf
> ===================================================================
> --- build.conf (revision 6047)
> +++ build.conf (working copy)
> @@ -143,7 +143,7 @@
> type = lib
> path = subversion/libsvn_ra_dav
> install = dav-lib
> -libs = libsvn_subr $(SVN_APRUTIL_LIBS) $(SVN_APR_LIBS) $(NEON_LIBS)
> +libs = libsvn_delta libsvn_subr $(SVN_APRUTIL_LIBS) $(SVN_APR_LIBS)
> $(NEON_LIBS)
> custom = ra-module
>
> # Accessing repositories via SVN
> @@ -151,7 +151,7 @@
> type = lib
> path = subversion/libsvn_ra_svn
> install = base-lib
> -libs = libsvn_subr $(SVN_APRUTIL_LIBS) $(SVN_APR_LIBS)
> +libs = libsvn_delta libsvn_subr $(SVN_APRUTIL_LIBS) $(SVN_APR_LIBS)
> custom = ra-module
>
> # Accessing repositories via direct libsvn_fs
>
>
> ---------------------------------------------------------------------
> To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
> For additional commands, e-mail: dev-help@subversion.tigris.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@subversion.tigris.org
For additional commands, e-mail: dev-help@subversion.tigris.org