You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@falcon.apache.org by "Ajay Yadava (JIRA)" <ji...@apache.org> on 2015/11/18 13:29:11 UTC

[jira] [Updated] (FALCON-1607) Code refactoring: Refactor ID into more specific sub classes

     [ https://issues.apache.org/jira/browse/FALCON-1607?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Ajay Yadava updated FALCON-1607:
--------------------------------
    Attachment:     (was: FALCON-1607.patch)

> Code refactoring: Refactor ID into more specific sub classes
> ------------------------------------------------------------
>
>                 Key: FALCON-1607
>                 URL: https://issues.apache.org/jira/browse/FALCON-1607
>             Project: Falcon
>          Issue Type: Improvement
>            Reporter: Ajay Yadava
>            Assignee: Ajay Yadava
>            Priority: Critical
>
> Currently the file ID.java is used to uniquely identify various "entities" for native scheduler. This class is overloaded and serves multiple tasks like getting an entity id for an entity and an instance id for an instance. Keeping all this code in one class creates various issues like no check on object creation - one can accidentally call an instance id when the underlying object was supposed to be  representing an entity etc. Since ID represents the unique identifier for an instance, entity etc. most methods pass ID and this makes the code hard to reason as we don't know what are we dealing with - an entity or an instance or something else.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)