You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by Jens Deppe <jd...@pivotal.io> on 2016/12/22 02:42:50 UTC
Review Request 54964: GEODE-2243: reference the formatter relative to
geode-core and not the root project
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54964/
-----------------------------------------------------------
Review request for geode, Anthony Baker, Mark Bretl, and Dan Smith.
Repository: geode
Description
-------
GEODE-2243: reference the formatter relative to geode-core and not the root project
Hopefully this change will be more accessible. Apologies for the previous breakage.
Diffs
-----
build.gradle 360310fbd58b97354b0b5fb60801540fe6f80dee
Diff: https://reviews.apache.org/r/54964/diff/
Testing
-------
Build under various root directory structures
Thanks,
Jens Deppe
Re: Review Request 54964: GEODE-2243: reference the formatter
relative to geode-core and not the root project
Posted by Dan Smith <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/54964/#review160020
-----------------------------------------------------------
Ship it!
Ship it- this works ... but I wonder if there is a better way to specify a path relative to the root of the geode checkout.
- Dan Smith
On Dec. 22, 2016, 2:42 a.m., Jens Deppe wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/54964/
> -----------------------------------------------------------
>
> (Updated Dec. 22, 2016, 2:42 a.m.)
>
>
> Review request for geode, Anthony Baker, Mark Bretl, and Dan Smith.
>
>
> Repository: geode
>
>
> Description
> -------
>
> GEODE-2243: reference the formatter relative to geode-core and not the root project
>
> Hopefully this change will be more accessible. Apologies for the previous breakage.
>
>
> Diffs
> -----
>
> build.gradle 360310fbd58b97354b0b5fb60801540fe6f80dee
>
> Diff: https://reviews.apache.org/r/54964/diff/
>
>
> Testing
> -------
>
> Build under various root directory structures
>
>
> Thanks,
>
> Jens Deppe
>
>