[GitHub] dneuman64 closed pull request #2442: Improve TR logging when a certificate from TO fails to decode

[GitBox <gi...@apache.org>]

dneuman64 closed pull request #2442: Improve TR logging when a certificate from TO fails to decode
URL: https://github.com/apache/trafficcontrol/pull/2442
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/traffic_router/connector/src/main/java/com/comcast/cdn/traffic_control/traffic_router/secure/CertificateDataConverter.java b/traffic_router/connector/src/main/java/com/comcast/cdn/traffic_control/traffic_router/secure/CertificateDataConverter.java
index 6139c8222..bc37f640d 100644
--- a/traffic_router/connector/src/main/java/com/comcast/cdn/traffic_control/traffic_router/secure/CertificateDataConverter.java
+++ b/traffic_router/connector/src/main/java/com/comcast/cdn/traffic_control/traffic_router/secure/CertificateDataConverter.java
@@ -41,7 +41,9 @@ public HandshakeData toHandshakeData(final CertificateData certificateData) {
 				x509Chain.toArray(new X509Certificate[x509Chain.size()]), privateKey);
 
 		} catch (Exception e) {
-			log.error("Failed to convert certificate data from traffic ops to handshake data! " + e.getClass().getSimpleName() + ": " + e.getMessage(), e);
+			log.error("Failed to convert certificate data (delivery service = " + certificateData.getDeliveryservice()
+					+ ", hostname = " + certificateData.getHostname() + ") from traffic ops to handshake data! "
+					+ e.getClass().getSimpleName() + ": " + e.getMessage(), e);
 		}
 		return null;
 	}


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services