You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2022/10/23 06:06:34 UTC
[GitHub] [doris] adonis0147 opened a new pull request, #13583: [chore](macOS) Fix issues found on macOS x86_64
adonis0147 opened a new pull request, #13583:
URL: https://github.com/apache/doris/pull/13583
# Proposed changes
~~Issue Number: close #xxx~~
## Problem summary
Fix issues found on macOS x86_64.
1. Should use `brew --prefix` instead of `brew --repo` in start scripts.
2. `sprintf` is marked as a deprecated function in MacOSX sdk (13.0)
```shell
$ ls -l /Library/Developer/CommandLineTools/SDKs/MacOSX.sdk
/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk -> MacOSX13.0.sdk
$ clang --version
Apple clang version 14.0.0 (clang-1400.0.29.201)
Target: x86_64-apple-darwin21.6.0
Thread model: posix
InstalledDir: /Library/Developer/CommandLineTools/usr/bin
```
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
3. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
5. Does it need to update dependencies:
- [ ] Yes
- [ ] No
6. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 commented on pull request #13583: [chore](macOS) Fix issues found on macOS x86_64
Posted by GitBox <gi...@apache.org>.
adonis0147 commented on PR #13583:
URL: https://github.com/apache/doris/pull/13583#issuecomment-1288103846
> Maybe it's ready to add document for macos build on doris website 😊
@SaintBacchus That is a good idea! I will do this job later.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] SaintBacchus commented on pull request #13583: [chore](macOS) Fix issues found on macOS x86_64
Posted by GitBox <gi...@apache.org>.
SaintBacchus commented on PR #13583:
URL: https://github.com/apache/doris/pull/13583#issuecomment-1288101553
Maybe it's ready to add document for macos build on doris website :blush:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] adonis0147 merged pull request #13583: [chore](macOS) Fix issues found on macOS x86_64
Posted by GitBox <gi...@apache.org>.
adonis0147 merged PR #13583:
URL: https://github.com/apache/doris/pull/13583
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org