You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ian Downes <ia...@gmail.com> on 2014/04/04 04:39:07 UTC
Review Request 20026: Support optional container set up commands and Linux
namespaces.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
Repository: mesos-git
Description
-------
Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
Modified LinuxLauncher to use clone() to optionally run a process in one or more different namespaces.
Diffs
-----
src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
src/slave/containerizer/linux_launcher.hpp 8f96c6996e0d06c37c29233f5e02f002db743dfb
src/slave/containerizer/linux_launcher.cpp 6515c0578071a815d0eebb120d9cb841f5e2d1d0
src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
Diff: https://reviews.apache.org/r/20026/diff/
Testing
-------
make check
Thanks,
Ian Downes
Re: Review Request 20026: Support optional container set up commands and
Linux namespaces.
Posted by Ian Downes <ia...@gmail.com>.
> On April 4, 2014, 4:26 p.m., Dominic Hamon wrote:
> > src/slave/containerizer/launcher.cpp, line 111
> > <https://reviews.apache.org/r/20026/diff/1/?file=548612#file548612line111>
> >
> > why is it declared with an int return value then?
This matches the signature that Linux clone requires.
- Ian
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/#review39548
-----------------------------------------------------------
On April 7, 2014, 8:23 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20026/
> -----------------------------------------------------------
>
> (Updated April 7, 2014, 8:23 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
>
> Modified LinuxLauncher to use clone() to optionally run a process in one or more different namespaces.
>
>
> Diffs
> -----
>
> src/Makefile.am 95f133d0103fdebb6de279a07bbeefbf0355f5af
> src/slave/containerizer/cgroups_launcher.hpp db61107141f60dd13cfa13278a7daab16f0d108c
> src/slave/containerizer/cgroups_launcher.cpp 39f0e4c3baaed3403da160ba63dada4a53d9af09
> src/slave/containerizer/containerizer.cpp 344872a6485c5b0c2c68ddbe0190e52e99cc0b0c
> src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
> src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
> src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
> src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
> src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
> src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
> src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
> src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
> src/tests/isolator_tests.cpp dde977eed7716ee9d9e139607d8f5c06d5ca8e13
>
> Diff: https://reviews.apache.org/r/20026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20026: Support optional container set up commands and
Linux namespaces.
Posted by Dominic Hamon <dh...@twopensource.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/#review39548
-----------------------------------------------------------
src/slave/containerizer/launcher.cpp
<https://reviews.apache.org/r/20026/#comment71952>
why is it declared with an int return value then?
- Dominic Hamon
On April 3, 2014, 7:39 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20026/
> -----------------------------------------------------------
>
> (Updated April 3, 2014, 7:39 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
>
> Modified LinuxLauncher to use clone() to optionally run a process in one or more different namespaces.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
> src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
> src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
> src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
> src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
> src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
> src/slave/containerizer/linux_launcher.hpp 8f96c6996e0d06c37c29233f5e02f002db743dfb
> src/slave/containerizer/linux_launcher.cpp 6515c0578071a815d0eebb120d9cb841f5e2d1d0
> src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
> src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
>
> Diff: https://reviews.apache.org/r/20026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20026: Support optional container set up commands and
Linux namespaces.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/#review39582
-----------------------------------------------------------
Please add some tests to exercise the new code path.
src/slave/containerizer/isolator.hpp
<https://reviews.apache.org/r/20026/#comment72331>
Please adjust the comments here.
src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20026/#comment72332>
Do you need to setup the environment variables from CommandInfo?
src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20026/#comment72333>
Do you need to say something about the child script execution. For example, when it will be executed?
src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20026/#comment72006>
s/executoro/executor/
src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20026/#comment72330>
Seems that 'fork' here now has isolate + fetch + exec. You may wanna do one of the following:
1) rename 'fork' to '_launch' as it is now really a continuation of 'launch'.
2) keep the existing flow in 'launch' and use partial bind for 'inChild'.
I personally prefer the second option:)
- Jie Yu
On April 7, 2014, 8:23 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20026/
> -----------------------------------------------------------
>
> (Updated April 7, 2014, 8:23 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
>
> Modified LinuxLauncher to use clone() to optionally run a process in one or more different namespaces.
>
>
> Diffs
> -----
>
> src/Makefile.am 95f133d0103fdebb6de279a07bbeefbf0355f5af
> src/slave/containerizer/cgroups_launcher.hpp db61107141f60dd13cfa13278a7daab16f0d108c
> src/slave/containerizer/cgroups_launcher.cpp 39f0e4c3baaed3403da160ba63dada4a53d9af09
> src/slave/containerizer/containerizer.cpp 344872a6485c5b0c2c68ddbe0190e52e99cc0b0c
> src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
> src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
> src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
> src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
> src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
> src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
> src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
> src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
> src/tests/isolator_tests.cpp dde977eed7716ee9d9e139607d8f5c06d5ca8e13
>
> Diff: https://reviews.apache.org/r/20026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20026: Support optional container set up commands and
Linux namespaces.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/#review39727
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20026]
All tests passed.
- Mesos ReviewBot
On April 7, 2014, 8:23 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20026/
> -----------------------------------------------------------
>
> (Updated April 7, 2014, 8:23 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
>
> Modified LinuxLauncher to use clone() to optionally run a process in one or more different namespaces.
>
>
> Diffs
> -----
>
> src/Makefile.am 95f133d0103fdebb6de279a07bbeefbf0355f5af
> src/slave/containerizer/cgroups_launcher.hpp db61107141f60dd13cfa13278a7daab16f0d108c
> src/slave/containerizer/cgroups_launcher.cpp 39f0e4c3baaed3403da160ba63dada4a53d9af09
> src/slave/containerizer/containerizer.cpp 344872a6485c5b0c2c68ddbe0190e52e99cc0b0c
> src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
> src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
> src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
> src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
> src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
> src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
> src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
> src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
> src/tests/isolator_tests.cpp dde977eed7716ee9d9e139607d8f5c06d5ca8e13
>
> Diff: https://reviews.apache.org/r/20026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20026: Support optional container set up commands and
Linux namespaces.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/#review39896
-----------------------------------------------------------
Bad patch!
Reviews applied: [20026]
Failed command: git apply --index 20026.patch
Error:
error: src/slave/containerizer/linux_launcher.hpp: does not exist in index
error: src/slave/containerizer/linux_launcher.cpp: does not exist in index
error: patch failed: src/tests/containerizer_tests.cpp:21
error: src/tests/containerizer_tests.cpp: patch does not apply
- Mesos ReviewBot
On April 8, 2014, 8:37 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20026/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 8:37 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
>
> Modified LinuxLauncher to use clone() to optionally run a process in one or more different namespaces.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
> src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
> src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
> src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
> src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
> src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
> src/slave/containerizer/linux_launcher.hpp 8f96c6996e0d06c37c29233f5e02f002db743dfb
> src/slave/containerizer/linux_launcher.cpp 530e0bd64d71bad761a2eab3d6e2f2179a167b4b
> src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
> src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
> src/tests/containerizer_tests.cpp b539070e3f76bb878bd3aeb04da93f25bdcecbeb
> src/tests/isolator.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20026: Support optional container set up commands.
Posted by Jie Yu <yu...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/#review41717
-----------------------------------------------------------
Ship it!
Great tests! LGTM.
src/slave/containerizer/isolator.hpp
<https://reviews.apache.org/r/20026/#comment75288>
The environment is also ignored, right? Do we plan to support environment in the future? If yes, maybe a TODO is more appropriate.
src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20026/#comment75290>
In fact, anything involving Try (thus new operator) is not async signal safe. Maybe a TODO here. We should avoid using stout/os functions in child context unless they are made async signal safe (like os::system).
src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20026/#comment75281>
Kill the new line here.
src/tests/containerizer_tests.cpp
<https://reviews.apache.org/r/20026/#comment75297>
protected?
src/tests/containerizer_tests.cpp
<https://reviews.apache.org/r/20026/#comment75299>
Get rid of std:: here and everywhere else.
- Jie Yu
On April 28, 2014, 11:42 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20026/
> -----------------------------------------------------------
>
> (Updated April 28, 2014, 11:42 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
> src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
> src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
> src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
> src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
> src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
> src/slave/containerizer/mesos_containerizer.hpp 99c1354366b3fc99f57773aeb3beece6c6544da2
> src/slave/containerizer/mesos_containerizer.cpp 27813af2c132e094a26a4aa31929d7aa84ddd969
> src/tests/containerizer_tests.cpp cea58cd8291201fa2dfcb934bfe371ddecdd1cc2
> src/tests/isolator.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20026: Support optional container set up commands.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/#review41735
-----------------------------------------------------------
Ship it!
src/slave/containerizer/isolators/cgroups/cpushare.cpp
<https://reviews.apache.org/r/20026/#comment75328>
no need for ";" at the end.
also, why prefix with "_". have we used this style before?
src/slave/containerizer/isolators/cgroups/mem.cpp
<https://reviews.apache.org/r/20026/#comment75329>
ditto.
src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20026/#comment75322>
s/scripts/commands/ ?
I'm assuming these needn't always be scripts?
src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20026/#comment75323>
Include the script (or command) name here to make it easy to debug?
src/slave/containerizer/mesos_containerizer.cpp
<https://reviews.apache.org/r/20026/#comment75324>
s/inChild/childFunction/ to be consistent with the param name?
src/tests/containerizer_tests.cpp
<https://reviews.apache.org/r/20026/#comment75332>
why the change in brace type?
src/tests/containerizer_tests.cpp
<https://reviews.apache.org/r/20026/#comment75335>
move this to tests/mesos.hpp?
- Vinod Kone
On April 29, 2014, 6:24 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20026/
> -----------------------------------------------------------
>
> (Updated April 29, 2014, 6:24 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
> src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
> src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
> src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
> src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
> src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
> src/slave/containerizer/mesos_containerizer.hpp 9be1b67f6afc63f275474b091a2df55d38cf032f
> src/slave/containerizer/mesos_containerizer.cpp 2c64f2d70251b154fb023c152a2dea4575c409a4
> src/tests/containerizer_tests.cpp cea58cd8291201fa2dfcb934bfe371ddecdd1cc2
> src/tests/isolator.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20026: Support optional container set up commands.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/
-----------------------------------------------------------
(Updated April 29, 2014, 11:24 a.m.)
Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
Changes
-------
Rebased and addressed Jie's comments.
Repository: mesos-git
Description
-------
Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
Diffs (updated)
-----
src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
src/slave/containerizer/mesos_containerizer.hpp 9be1b67f6afc63f275474b091a2df55d38cf032f
src/slave/containerizer/mesos_containerizer.cpp 2c64f2d70251b154fb023c152a2dea4575c409a4
src/tests/containerizer_tests.cpp cea58cd8291201fa2dfcb934bfe371ddecdd1cc2
src/tests/isolator.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/20026/diff/
Testing
-------
make check
Thanks,
Ian Downes
Re: Review Request 20026: Support optional container set up commands.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/
-----------------------------------------------------------
(Updated April 28, 2014, 11:42 p.m.)
Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
Changes
-------
Rebased.
Split changes to the Linux launcher into an additional review.
Summary (updated)
-----------------
Support optional container set up commands.
Repository: mesos-git
Description (updated)
-------
Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
Diffs (updated)
-----
src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
src/slave/containerizer/mesos_containerizer.hpp 99c1354366b3fc99f57773aeb3beece6c6544da2
src/slave/containerizer/mesos_containerizer.cpp 27813af2c132e094a26a4aa31929d7aa84ddd969
src/tests/containerizer_tests.cpp cea58cd8291201fa2dfcb934bfe371ddecdd1cc2
src/tests/isolator.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/20026/diff/
Testing
-------
make check
Thanks,
Ian Downes
Re: Review Request 20026: Support optional container set up commands and
Linux namespaces.
Posted by Vinod Kone <vi...@gmail.com>.
> On April 9, 2014, 11:28 p.m., Vinod Kone wrote:
> > This review looks like it could really use a split, one for the api change and one for clone?
also re-add the "depends on" to make reviewbot happy. i hate that post-review auto removes the field on review updates :( couldn't figure out a fix so far.
- Vinod
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/#review39963
-----------------------------------------------------------
On April 8, 2014, 8:37 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20026/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 8:37 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
>
> Modified LinuxLauncher to use clone() to optionally run a process in one or more different namespaces.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
> src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
> src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
> src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
> src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
> src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
> src/slave/containerizer/linux_launcher.hpp 8f96c6996e0d06c37c29233f5e02f002db743dfb
> src/slave/containerizer/linux_launcher.cpp 530e0bd64d71bad761a2eab3d6e2f2179a167b4b
> src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
> src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
> src/tests/containerizer_tests.cpp b539070e3f76bb878bd3aeb04da93f25bdcecbeb
> src/tests/isolator.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20026: Support optional container set up commands and
Linux namespaces.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/#review39963
-----------------------------------------------------------
This review looks like it could really use a split, one for the api change and one for clone?
- Vinod Kone
On April 8, 2014, 8:37 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20026/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 8:37 p.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
>
> Modified LinuxLauncher to use clone() to optionally run a process in one or more different namespaces.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
> src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
> src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
> src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
> src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
> src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
> src/slave/containerizer/linux_launcher.hpp 8f96c6996e0d06c37c29233f5e02f002db743dfb
> src/slave/containerizer/linux_launcher.cpp 530e0bd64d71bad761a2eab3d6e2f2179a167b4b
> src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
> src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
> src/tests/containerizer_tests.cpp b539070e3f76bb878bd3aeb04da93f25bdcecbeb
> src/tests/isolator.hpp PRE-CREATION
>
> Diff: https://reviews.apache.org/r/20026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>
Re: Review Request 20026: Support optional container set up commands and
Linux namespaces.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/
-----------------------------------------------------------
(Updated April 8, 2014, 8:37 p.m.)
Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
Changes
-------
Added tests and rebased.
Repository: mesos-git
Description
-------
Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
Modified LinuxLauncher to use clone() to optionally run a process in one or more different namespaces.
Diffs (updated)
-----
src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
src/slave/containerizer/linux_launcher.hpp 8f96c6996e0d06c37c29233f5e02f002db743dfb
src/slave/containerizer/linux_launcher.cpp 530e0bd64d71bad761a2eab3d6e2f2179a167b4b
src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
src/tests/containerizer_tests.cpp b539070e3f76bb878bd3aeb04da93f25bdcecbeb
src/tests/isolator.hpp PRE-CREATION
Diff: https://reviews.apache.org/r/20026/diff/
Testing
-------
make check
Thanks,
Ian Downes
Re: Review Request 20026: Support optional container set up commands and
Linux namespaces.
Posted by Ian Downes <ia...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/
-----------------------------------------------------------
(Updated April 7, 2014, 8:23 p.m.)
Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
Changes
-------
Fixed diff for renamed files.
Repository: mesos-git
Description
-------
Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
Modified LinuxLauncher to use clone() to optionally run a process in one or more different namespaces.
Diffs (updated)
-----
src/Makefile.am 95f133d0103fdebb6de279a07bbeefbf0355f5af
src/slave/containerizer/cgroups_launcher.hpp db61107141f60dd13cfa13278a7daab16f0d108c
src/slave/containerizer/cgroups_launcher.cpp 39f0e4c3baaed3403da160ba63dada4a53d9af09
src/slave/containerizer/containerizer.cpp 344872a6485c5b0c2c68ddbe0190e52e99cc0b0c
src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
src/tests/isolator_tests.cpp dde977eed7716ee9d9e139607d8f5c06d5ca8e13
Diff: https://reviews.apache.org/r/20026/diff/
Testing
-------
make check
Thanks,
Ian Downes
Re: Review Request 20026: Support optional container set up commands and
Linux namespaces.
Posted by Mesos ReviewBot <de...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20026/#review39556
-----------------------------------------------------------
Patch looks great!
Reviews applied: [20025, 20026]
All tests passed.
- Mesos ReviewBot
On April 4, 2014, 2:39 a.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20026/
> -----------------------------------------------------------
>
> (Updated April 4, 2014, 2:39 a.m.)
>
>
> Review request for mesos, Benjamin Hindman, Chi Zhang, Jie Yu, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> Modified Isolator API so optional commands are returned from prepare and run in the child before exec'ing the executor.
>
> Modified LinuxLauncher to use clone() to optionally run a process in one or more different namespaces.
>
>
> Diffs
> -----
>
> src/slave/containerizer/isolator.hpp d410c73c5feac9cbd391b7a2b66141aa9aa75423
> src/slave/containerizer/isolator.cpp f7935b3f20530e9c5558a636f40d69371a963102
> src/slave/containerizer/isolators/cgroups/cpushare.hpp 49cc5bc2407e99c81e0a8eaff11cffd1136b019c
> src/slave/containerizer/isolators/cgroups/cpushare.cpp 11665dbe88e3920fd9d8a2259987611d49e85462
> src/slave/containerizer/isolators/cgroups/mem.hpp ffd81b330202ad6eff48940b762e3f7105008b4b
> src/slave/containerizer/isolators/cgroups/mem.cpp 9e9c55e37f499898196b61cc586cb0e49feabf56
> src/slave/containerizer/isolators/posix.hpp 7fbc6ddd9aa5518870bf938c6ead5eb72d3ec524
> src/slave/containerizer/launcher.hpp dee526f254d56a7a974a70522cd0ca059814fb6d
> src/slave/containerizer/launcher.cpp c83327b2f13f0511c8e4e0e9902bc6a1e1328283
> src/slave/containerizer/linux_launcher.hpp 8f96c6996e0d06c37c29233f5e02f002db743dfb
> src/slave/containerizer/linux_launcher.cpp 6515c0578071a815d0eebb120d9cb841f5e2d1d0
> src/slave/containerizer/mesos_containerizer.hpp ee1fd3010b4a178a6abcbd813af5eba4d564be00
> src/slave/containerizer/mesos_containerizer.cpp c819c97d96d232a1de3c1ed2fc848bebf66981f7
>
> Diff: https://reviews.apache.org/r/20026/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Ian Downes
>
>