You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by GitBox <gi...@apache.org> on 2022/11/09 22:48:54 UTC

[GitHub] [helix] mgao0 commented on a diff in pull request #2271: 2270/custom ca

mgao0 commented on code in PR #2271:
URL: https://github.com/apache/helix/pull/2271#discussion_r1018484913


##########
helix-front/server/controllers/d.ts:
##########
@@ -1,6 +1,7 @@
 import { Request } from 'express';
+import request from 'request';
 
-export interface HelixUserRequest extends Request {
+export interface HelixRequest extends Request {

Review Comment:
   Is there a reason for changing interface name here? Could this change break backward compatibility?



##########
helix-front/angular.json:
##########
@@ -72,7 +72,8 @@
         "serve": {
           "builder": "@angular-devkit/build-angular:dev-server",
           "options": {
-            "proxyConfig": "./proxy.conf.json"
+            "proxyConfig": "./proxy.conf.json",
+            "disableHostCheck": true

Review Comment:
   Could you please explain this option? I don't have much context here. Thanks.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org