You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sentry.apache.org by Sergio Pena via Review Board <no...@reviews.apache.org> on 2017/10/13 15:46:38 UTC
Review Request 62979: SENTRY-1985: Sentry should log in stdout when
it is ready to serve requests
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62979/
-----------------------------------------------------------
Review request for sentry, Alexander Kolbasov and kalyan kumar kalvagadda.
Bugs: sentry-1985
https://issues.apache.org/jira/browse/sentry-1985
Repository: sentry
Description
-------
Display when Sentry is ready to serve on the console output.
Diffs
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 31fd4597dad6b02bb5d8b9f944a488f6f78d7d79
Diff: https://reviews.apache.org/r/62979/diff/1/
Testing
-------
Thanks,
Sergio Pena
Re: Review Request 62979: SENTRY-1985: Sentry should log in stdout
when it is ready to serve requests
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
> On Oct. 13, 2017, 4:39 p.m., Na Li wrote:
> > should SentryService log the sentry service is ready? You only logged HMSFollower is ready
In order to figure out the service is ready than we need to do it on the HMSFollower because it needs to know when it finishes getting an snapshot.
- Sergio
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62979/#review187979
-----------------------------------------------------------
On Oct. 13, 2017, 3:46 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62979/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 3:46 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and kalyan kumar kalvagadda.
>
>
> Bugs: sentry-1985
> https://issues.apache.org/jira/browse/sentry-1985
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Display when Sentry is ready to serve on the console output.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 31fd4597dad6b02bb5d8b9f944a488f6f78d7d79
>
>
> Diff: https://reviews.apache.org/r/62979/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 62979: SENTRY-1985: Sentry should log in stdout
when it is ready to serve requests
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62979/#review187979
-----------------------------------------------------------
should SentryService log the sentry service is ready? You only logged HMSFollower is ready
- Na Li
On Oct. 13, 2017, 3:46 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62979/
> -----------------------------------------------------------
>
> (Updated Oct. 13, 2017, 3:46 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and kalyan kumar kalvagadda.
>
>
> Bugs: sentry-1985
> https://issues.apache.org/jira/browse/sentry-1985
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Display when Sentry is ready to serve on the console output.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 31fd4597dad6b02bb5d8b9f944a488f6f78d7d79
>
>
> Diff: https://reviews.apache.org/r/62979/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 62979: SENTRY-1985: Sentry should log in stdout
when it is ready to serve requests
Posted by Alexander Kolbasov <ak...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62979/#review188141
-----------------------------------------------------------
Ship it!
Ship It!
- Alexander Kolbasov
On Oct. 16, 2017, 3:35 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62979/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 3:35 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and kalyan kumar kalvagadda.
>
>
> Bugs: sentry-1985
> https://issues.apache.org/jira/browse/sentry-1985
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Display when Sentry is ready to serve on the console output.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 31fd4597dad6b02bb5d8b9f944a488f6f78d7d79
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java d2a4c2dc2607f5095855e9769bb6597893c0aa49
>
>
> Diff: https://reviews.apache.org/r/62979/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 62979: SENTRY-1985: Sentry should log in stdout
when it is ready to serve requests
Posted by kalyan kumar kalvagadda via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62979/#review188143
-----------------------------------------------------------
Ship it!
Ship It!
- kalyan kumar kalvagadda
On Oct. 16, 2017, 3:35 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62979/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 3:35 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and kalyan kumar kalvagadda.
>
>
> Bugs: sentry-1985
> https://issues.apache.org/jira/browse/sentry-1985
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Display when Sentry is ready to serve on the console output.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 31fd4597dad6b02bb5d8b9f944a488f6f78d7d79
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java d2a4c2dc2607f5095855e9769bb6597893c0aa49
>
>
> Diff: https://reviews.apache.org/r/62979/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 62979: SENTRY-1985: Sentry should log in stdout
when it is ready to serve requests
Posted by Na Li via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62979/#review188196
-----------------------------------------------------------
Ship it!
Ship It!
- Na Li
On Oct. 16, 2017, 3:35 p.m., Sergio Pena wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/62979/
> -----------------------------------------------------------
>
> (Updated Oct. 16, 2017, 3:35 p.m.)
>
>
> Review request for sentry, Alexander Kolbasov and kalyan kumar kalvagadda.
>
>
> Bugs: sentry-1985
> https://issues.apache.org/jira/browse/sentry-1985
>
>
> Repository: sentry
>
>
> Description
> -------
>
> Display when Sentry is ready to serve on the console output.
>
>
> Diffs
> -----
>
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 31fd4597dad6b02bb5d8b9f944a488f6f78d7d79
> sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java d2a4c2dc2607f5095855e9769bb6597893c0aa49
>
>
> Diff: https://reviews.apache.org/r/62979/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sergio Pena
>
>
Re: Review Request 62979: SENTRY-1985: Sentry should log in stdout
when it is ready to serve requests
Posted by Sergio Pena via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/62979/
-----------------------------------------------------------
(Updated Oct. 16, 2017, 3:35 p.m.)
Review request for sentry, Alexander Kolbasov and kalyan kumar kalvagadda.
Bugs: sentry-1985
https://issues.apache.org/jira/browse/sentry-1985
Repository: sentry
Description
-------
Display when Sentry is ready to serve on the console output.
Diffs (updated)
-----
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/HMSFollower.java 31fd4597dad6b02bb5d8b9f944a488f6f78d7d79
sentry-provider/sentry-provider-db/src/main/java/org/apache/sentry/service/thrift/SentryService.java d2a4c2dc2607f5095855e9769bb6597893c0aa49
Diff: https://reviews.apache.org/r/62979/diff/2/
Changes: https://reviews.apache.org/r/62979/diff/1-2/
Testing
-------
Thanks,
Sergio Pena