You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@kvrocks.apache.org by GitBox <gi...@apache.org> on 2022/07/19 13:52:13 UTC

[GitHub] [incubator-kvrocks] git-hulk commented on a diff in pull request #714: Fix use after free and some memory leaks which reported by ASan

git-hulk commented on code in PR #714:
URL: https://github.com/apache/incubator-kvrocks/pull/714#discussion_r924531026


##########
src/redis_request.h:
##########
@@ -55,7 +55,7 @@ class Request {
   int64_t multi_bulk_len_ = 0;
   size_t bulk_len_ = 0;
   CommandTokens tokens_;
-  std::vector<CommandTokens> commands_;
+  std::list<CommandTokens> commands_;

Review Comment:
   Do you mean deque will performance better than list in this case?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@kvrocks.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org