You are viewing a plain text version of this content. The canonical link for it is here.
Posted to java-dev@axis.apache.org by Thilina Gunarathne <cs...@gmail.com> on 2006/01/30 14:12:23 UTC
[Axis2] Setting Reference Properties in Axis2 Addressing
Hi devs,
These days I'm trying to update the Kandula2 code base to be compatible with
current Axis2. It seems Axis2 has gone a long way and now I'm getting tired
running after it to catch it. Now I'm facing with several problems.
It seems the current Axis2 addressing allows users to set only OMElements as
reference properties. Earlier we just had to set a key value pair in a hash
map to do this. My knowledge in Addressing is very minimal. But
IMHO setting OMElements as reference properties/parameteres in a HashMap is
bit troublesome. It took me great deal of time to find the erroras this new
approach does not give us a single clue that we should use OMElements
instead of key value pairs as earlier.
At least we need to change the Epr.setReferenceParameters(HashMap map);
method signature in order to make users aware of the type they needs to
use..... Personally I'm not even with the idea of using OMElements. I don't
think the users will like the idea of touching OMElements in order to set
Reference Properties...
Please let us know if there are plans to change these things as we are
thinking of cutting a Milestone in Kandula2 soon and Kandula2 depends
heavily on Reference Properties....
Thanks,
~Thilina
--
"May the SourcE be with u"
http://webservices.apache.org/~thilina/
http://thilinag.blogspot.com/
http://www.bloglines.com/blog/Thilina
Re: [Axis2] Setting Reference Properties in Axis2 Addressing
Posted by Sanjiva Weerawarana <sa...@opensource.lk>.
On Mon, 2006-01-30 at 21:55 +0600, Thilina Gunarathne wrote:
> Hi,
> Yep... I too agree that it's correct.....
> My concern is using as a user is error prone and cumbersome..
>
> I suggest at least we should change the following methode sig.
> Epr.setReferenceParameters(HashMap map);
> to
> Epr.addReferenceParameters(OMElement);
+1, except it should be addReferenceParameter (OMElement) not
parameters.
I'd be +1 for adding a simple convenience method as we have in
ServiceClient to add string-valued ref parameters:
EPR.addStringReferenceParameter (QName, paramName, String paramValue);
Sanjiva.
Re: [Axis2] Setting Reference Properties in Axis2 Addressing
Posted by Srinath Perera <he...@gmail.com>.
+1, use typed interfaces as much as possible
Thanks
Srinath
On 1/30/06, Thilina Gunarathne <cs...@gmail.com> wrote:
> Hi,
> Yep... I too agree that it's correct.....
> My concern is using as a user is error prone and cumbersome..
>
> I suggest at least we should change the following methode sig.
> Epr.setReferenceParameters(HashMap map);
> to
>
> Epr.addReferenceParameters(OMElement);
>
> (I spent almost half a day tracking the Nullpointer, which later found out
> to be a ClassCast Exception)
> We can use something like a array list underneath....At the same time it
> would be marvelous if we can do something like Dims suggested...
>
> Thanks,
> ~Thilina
>
> On 1/30/06, Davanum Srinivas <da...@gmail.com> wrote:
> > Eran,
> >
> > I agree that the current implementation is correct, but Could we make
> > it more convenient by adding code that transforms strings into
> > whatever is needed under the covers?
> >
> > thanks,
> > dims
> >
> > On 1/30/06, Eran Chinthaka <ch...@opensource.lk> wrote:
> > > -----BEGIN PGP SIGNED MESSAGE-----
> > > Hash: SHA1
> > >
> > > Hi Thilina,
> > >
> > > WS-Addressing specification defines reference parameters as of type
> > > xs:any [1]. So I accept that my earlier implementation was wrong,
> > > which limited for someone to add any content as a reference parameter.
> > > (Thanks Steve and Sanjiva for pointing that out).
> > >
> > > So I changed the impl to make ref param to contain an OMElement which
> > > is the best match to represent xs:any. So IMO, the current impl is
> > > correct.
> > >
> > >
> > >
> > > - -- Chinthaka
> > >
> > > [1] -
> http://www.w3.org/TR/2005/CR-ws-addr-core-20050817/#eprinfomodel
> > >
> > > Thilina Gunarathne wrote:
> > >
> > > > Hi devs, These days I'm trying to update the Kandula2 code base to
> > > > be compatible with current Axis2. It seems Axis2 has gone a long
> > > > way and now I'm getting tired running after it to catch it. Now I'm
> > > > facing with several problems.
> > > >
> > > > It seems the current Axis2 addressing allows users to set only
> > > > OMElements as reference properties. Earlier we just had to set a
> > > > key value pair in a hash map to do this. My knowledge in
> > > > Addressing is very minimal. But IMHO setting OMElements as
> > > > reference properties/parameteres in a HashMap is bit troublesome.
> > > > It took me great deal of time to find the erroras this new approach
> > > > does not give us a single clue that we should use OMElements
> > > > instead of key value pairs as earlier.
> > > >
> > > > At least we need to change the Epr.setReferenceParameters(HashMap
> > > > map); method signature in order to make users aware of the type
> > > > they needs to use..... Personally I'm not even with the idea of
> > > > using OMElements. I don't think the users will like the idea of
> > > > touching OMElements in order to set Reference Properties...
> > > >
> > > > Please let us know if there are plans to change these things as we
> > > > are thinking of cutting a Milestone in Kandula2 soon and Kandula2
> > > > depends heavily on Reference Properties....
> > > >
> > > > Thanks,
> > > >
> > > > ~Thilina
> > > >
> > > > -- "May the SourcE be with u"
> > > > http://webservices.apache.org/~thilina/
> > > > http://thilinag.blogspot.com/
> http://www.bloglines.com/blog/Thilina
> > > >
> > > >
> > > -----BEGIN PGP SIGNATURE-----
> > > Version: GnuPG v1.4.2 (MingW32)
> > >
> > >
> iD8DBQFD3iGQjON2uBzUhh8RAsSyAJ4qNoM65xc3uvbUWkBV1H3E+LKnAQCfXRek
> > > 0AdvWnonspwgbBppLvlBT3Y=
> > > =WkUi
> > > -----END PGP SIGNATURE-----
> > >
> > >
> >
> >
> > --
> > Davanum Srinivas : http://wso2.com/blogs/
> >
>
>
>
> --
> "May the SourcE be with u"
> http://webservices.apache.org/~thilina/
> http://thilinag.blogspot.com/
> http://www.bloglines.com/blog/Thilina
--
============================
Srinath Perera:
http://www.cs.indiana.edu/~hperera/
http://www.bloglines.com/blog/hemapani
Re: [Axis2] Setting Reference Properties in Axis2 Addressing
Posted by Thilina Gunarathne <cs...@gmail.com>.
Hi,
Yep... I too agree that it's correct.....
My concern is using as a user is error prone and cumbersome..
I suggest at least we should change the following methode sig.
Epr.setReferenceParameters(HashMap map);
to
Epr.addReferenceParameters(OMElement);
(I spent almost half a day tracking the Nullpointer, which later found out
to be a ClassCast Exception)
We can use something like a array list underneath....At the same time it
would be marvelous if we can do something like Dims suggested...
Thanks,
~Thilina
On 1/30/06, Davanum Srinivas <da...@gmail.com> wrote:
>
> Eran,
>
> I agree that the current implementation is correct, but Could we make
> it more convenient by adding code that transforms strings into
> whatever is needed under the covers?
>
> thanks,
> dims
>
> On 1/30/06, Eran Chinthaka <ch...@opensource.lk> wrote:
> > -----BEGIN PGP SIGNED MESSAGE-----
> > Hash: SHA1
> >
> > Hi Thilina,
> >
> > WS-Addressing specification defines reference parameters as of type
> > xs:any [1]. So I accept that my earlier implementation was wrong,
> > which limited for someone to add any content as a reference parameter.
> > (Thanks Steve and Sanjiva for pointing that out).
> >
> > So I changed the impl to make ref param to contain an OMElement which
> > is the best match to represent xs:any. So IMO, the current impl is
> > correct.
> >
> >
> >
> > - -- Chinthaka
> >
> > [1] - http://www.w3.org/TR/2005/CR-ws-addr-core-20050817/#eprinfomodel
> >
> > Thilina Gunarathne wrote:
> >
> > > Hi devs, These days I'm trying to update the Kandula2 code base to
> > > be compatible with current Axis2. It seems Axis2 has gone a long
> > > way and now I'm getting tired running after it to catch it. Now I'm
> > > facing with several problems.
> > >
> > > It seems the current Axis2 addressing allows users to set only
> > > OMElements as reference properties. Earlier we just had to set a
> > > key value pair in a hash map to do this. My knowledge in
> > > Addressing is very minimal. But IMHO setting OMElements as
> > > reference properties/parameteres in a HashMap is bit troublesome.
> > > It took me great deal of time to find the erroras this new approach
> > > does not give us a single clue that we should use OMElements
> > > instead of key value pairs as earlier.
> > >
> > > At least we need to change the Epr.setReferenceParameters(HashMap
> > > map); method signature in order to make users aware of the type
> > > they needs to use..... Personally I'm not even with the idea of
> > > using OMElements. I don't think the users will like the idea of
> > > touching OMElements in order to set Reference Properties...
> > >
> > > Please let us know if there are plans to change these things as we
> > > are thinking of cutting a Milestone in Kandula2 soon and Kandula2
> > > depends heavily on Reference Properties....
> > >
> > > Thanks,
> > >
> > > ~Thilina
> > >
> > > -- "May the SourcE be with u"
> > > http://webservices.apache.org/~thilina/
> > > http://thilinag.blogspot.com/ http://www.bloglines.com/blog/Thilina
> > >
> > >
> > -----BEGIN PGP SIGNATURE-----
> > Version: GnuPG v1.4.2 (MingW32)
> >
> > iD8DBQFD3iGQjON2uBzUhh8RAsSyAJ4qNoM65xc3uvbUWkBV1H3E+LKnAQCfXRek
> > 0AdvWnonspwgbBppLvlBT3Y=
> > =WkUi
> > -----END PGP SIGNATURE-----
> >
> >
>
>
> --
> Davanum Srinivas : http://wso2.com/blogs/
>
--
"May the SourcE be with u"
http://webservices.apache.org/~thilina/
http://thilinag.blogspot.com/
http://www.bloglines.com/blog/Thilina
Re: [Axis2] Setting Reference Properties in Axis2 Addressing
Posted by Davanum Srinivas <da...@gmail.com>.
Eran,
I agree that the current implementation is correct, but Could we make
it more convenient by adding code that transforms strings into
whatever is needed under the covers?
thanks,
dims
On 1/30/06, Eran Chinthaka <ch...@opensource.lk> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi Thilina,
>
> WS-Addressing specification defines reference parameters as of type
> xs:any [1]. So I accept that my earlier implementation was wrong,
> which limited for someone to add any content as a reference parameter.
> (Thanks Steve and Sanjiva for pointing that out).
>
> So I changed the impl to make ref param to contain an OMElement which
> is the best match to represent xs:any. So IMO, the current impl is
> correct.
>
>
>
> - -- Chinthaka
>
> [1] - http://www.w3.org/TR/2005/CR-ws-addr-core-20050817/#eprinfomodel
>
> Thilina Gunarathne wrote:
>
> > Hi devs, These days I'm trying to update the Kandula2 code base to
> > be compatible with current Axis2. It seems Axis2 has gone a long
> > way and now I'm getting tired running after it to catch it. Now I'm
> > facing with several problems.
> >
> > It seems the current Axis2 addressing allows users to set only
> > OMElements as reference properties. Earlier we just had to set a
> > key value pair in a hash map to do this. My knowledge in
> > Addressing is very minimal. But IMHO setting OMElements as
> > reference properties/parameteres in a HashMap is bit troublesome.
> > It took me great deal of time to find the erroras this new approach
> > does not give us a single clue that we should use OMElements
> > instead of key value pairs as earlier.
> >
> > At least we need to change the Epr.setReferenceParameters(HashMap
> > map); method signature in order to make users aware of the type
> > they needs to use..... Personally I'm not even with the idea of
> > using OMElements. I don't think the users will like the idea of
> > touching OMElements in order to set Reference Properties...
> >
> > Please let us know if there are plans to change these things as we
> > are thinking of cutting a Milestone in Kandula2 soon and Kandula2
> > depends heavily on Reference Properties....
> >
> > Thanks,
> >
> > ~Thilina
> >
> > -- "May the SourcE be with u"
> > http://webservices.apache.org/~thilina/
> > http://thilinag.blogspot.com/ http://www.bloglines.com/blog/Thilina
> >
> >
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v1.4.2 (MingW32)
>
> iD8DBQFD3iGQjON2uBzUhh8RAsSyAJ4qNoM65xc3uvbUWkBV1H3E+LKnAQCfXRek
> 0AdvWnonspwgbBppLvlBT3Y=
> =WkUi
> -----END PGP SIGNATURE-----
>
>
--
Davanum Srinivas : http://wso2.com/blogs/
Re: [Axis2] Setting Reference Properties in Axis2 Addressing
Posted by Eran Chinthaka <ch...@opensource.lk>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1
Hi Thilina,
WS-Addressing specification defines reference parameters as of type
xs:any [1]. So I accept that my earlier implementation was wrong,
which limited for someone to add any content as a reference parameter.
(Thanks Steve and Sanjiva for pointing that out).
So I changed the impl to make ref param to contain an OMElement which
is the best match to represent xs:any. So IMO, the current impl is
correct.
- -- Chinthaka
[1] - http://www.w3.org/TR/2005/CR-ws-addr-core-20050817/#eprinfomodel
Thilina Gunarathne wrote:
> Hi devs, These days I'm trying to update the Kandula2 code base to
> be compatible with current Axis2. It seems Axis2 has gone a long
> way and now I'm getting tired running after it to catch it. Now I'm
> facing with several problems.
>
> It seems the current Axis2 addressing allows users to set only
> OMElements as reference properties. Earlier we just had to set a
> key value pair in a hash map to do this. My knowledge in
> Addressing is very minimal. But IMHO setting OMElements as
> reference properties/parameteres in a HashMap is bit troublesome.
> It took me great deal of time to find the erroras this new approach
> does not give us a single clue that we should use OMElements
> instead of key value pairs as earlier.
>
> At least we need to change the Epr.setReferenceParameters(HashMap
> map); method signature in order to make users aware of the type
> they needs to use..... Personally I'm not even with the idea of
> using OMElements. I don't think the users will like the idea of
> touching OMElements in order to set Reference Properties...
>
> Please let us know if there are plans to change these things as we
> are thinking of cutting a Milestone in Kandula2 soon and Kandula2
> depends heavily on Reference Properties....
>
> Thanks,
>
> ~Thilina
>
> -- "May the SourcE be with u"
> http://webservices.apache.org/~thilina/
> http://thilinag.blogspot.com/ http://www.bloglines.com/blog/Thilina
>
>
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.2 (MingW32)
iD8DBQFD3iGQjON2uBzUhh8RAsSyAJ4qNoM65xc3uvbUWkBV1H3E+LKnAQCfXRek
0AdvWnonspwgbBppLvlBT3Y=
=WkUi
-----END PGP SIGNATURE-----