You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by "BiteTheDDDDt (via GitHub)" <gi...@apache.org> on 2023/11/10 09:40:30 UTC
[PR] some fix [doris]
BiteTheDDDDt opened a new pull request, #26761:
URL: https://github.com/apache/doris/pull/26761
## Proposed changes
Issue Number: close #xxx
<!--Describe your changes.-->
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] some fix [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee commented on code in PR #26761:
URL: https://github.com/apache/doris/pull/26761#discussion_r1392163278
##########
be/src/pipeline/exec/hashjoin_probe_operator.cpp:
##########
@@ -90,6 +92,7 @@ Status HashJoinProbeLocalState::open(RuntimeState* state) {
void HashJoinProbeLocalState::prepare_for_next() {
_probe_index = 0;
_ready_probe = false;
+ _last_probe_match = size_t(1) + JOIN_BUILD_SIZE_LIMIT;
Review Comment:
use int type ？
##########
be/src/pipeline/exec/hashjoin_probe_operator.cpp:
##########
@@ -90,6 +92,7 @@ Status HashJoinProbeLocalState::open(RuntimeState* state) {
void HashJoinProbeLocalState::prepare_for_next() {
_probe_index = 0;
_ready_probe = false;
+ _last_probe_match = size_t(1) + JOIN_BUILD_SIZE_LIMIT;
Review Comment:
use int type ？
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] some fix [doris]
Posted by "HappenLee (via GitHub)" <gi...@apache.org>.
HappenLee merged PR #26761:
URL: https://github.com/apache/doris/pull/26761
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] some fix [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #26761:
URL: https://github.com/apache/doris/pull/26761#discussion_r1389173678
##########
be/src/vec/common/hash_table/hash_map.h:
##########
@@ -427,18 +437,20 @@ class JoinHashMapTable : public HashMapTable<Key, Cell, Hash, Grower, Allocator>
do_the_probe();
}
- probe_idx -= (matched_cnt == batch_size && build_idx);
+ probe_idx -=
+ (matched_cnt >= batch_size &&
+ build_idx); // FULL_OUTER_JOIN may over batch_size when emplace 0 into build_idxs
return std::tuple {probe_idx, build_idx, matched_cnt};
}
const Key* __restrict build_keys;
std::vector<uint8_t> visited;
- uint32_t bucket_size = 0;
- int max_batch_size = 0;
+ uint32_t bucket_size = 1;
+ int max_batch_size = 4064;
Review Comment:
warning: 4064 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
```cpp
int max_batch_size = 4064;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
Re: [PR] some fix [doris]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on code in PR #26761:
URL: https://github.com/apache/doris/pull/26761#discussion_r1392907131
##########
be/src/vec/common/hash_table/hash_map.h:
##########
@@ -434,11 +472,11 @@ class JoinHashMapTable : public HashMapTable<Key, Cell, Hash, Grower, Allocator>
const Key* __restrict build_keys;
std::vector<uint8_t> visited;
- uint32_t bucket_size = 0;
- int max_batch_size = 0;
+ uint32_t bucket_size = 1;
+ int max_batch_size = 4064;
- std::vector<uint32_t> first;
- std::vector<uint32_t> next;
+ std::vector<uint32_t> first = {0};
+ std::vector<uint32_t> next = {0};
Review Comment:
warning: 4064 is a magic number; consider replacing it with a named constant [readability-magic-numbers]
```cpp
int max_batch_size = 4064;
^
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org