You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/11 11:36:32 UTC
[GitHub] [doris] jackwener opened a new pull request, #15833: [fix](Nereids): add unusedFlag to avoid job run used GroupExprssion
jackwener opened a new pull request, #15833:
URL: https://github.com/apache/doris/pull/15833
# Proposed changes
Issue Number: close #xxx
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [ ] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [ ] No Need
3. Has document been added or modified:
- [ ] Yes
- [ ] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [ ] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [ ] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] morrySnow commented on a diff in pull request #15833: [fix](Nereids): add unusedFlag to avoid job run used GroupExprssion
Posted by GitBox <gi...@apache.org>.
morrySnow commented on code in PR #15833:
URL: https://github.com/apache/doris/pull/15833#discussion_r1067844668
##########
fe/fe-core/src/main/java/org/apache/doris/nereids/memo/Memo.java:
##########
@@ -465,6 +468,8 @@ public Group mergeGroup(Group source, Group destination) {
source.moveOwnership(destination);
groups.remove(source.getGroupId());
}
+
+ needMergeGroups.forEach(this::mergeGroup);
Review Comment:
consider a scenario:
if we have two entry in the map: B -> A and C -> B.
when we do merge group. we first merge B to A, and then B is removed. after that, we want to merge C to B, but B is not exist anymore.
So, maybe we need to use **disjoint set** do find a common parent, and then merge all other group to it in one **disjoint set**.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] jackwener closed pull request #15833: [fix](Nereids): add unusedFlag to avoid job run used GroupExprssion
Posted by GitBox <gi...@apache.org>.
jackwener closed pull request #15833: [fix](Nereids): add unusedFlag to avoid job run used GroupExprssion
URL: https://github.com/apache/doris/pull/15833
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15833: [fix](Nereids): add unusedFlag to avoid job run used GroupExprssion
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15833:
URL: https://github.com/apache/doris/pull/15833#issuecomment-1378797760
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 35.24 seconds
load time: 491 seconds
storage size: 17122493278 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230111140216_clickbench_pr_77845.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org