[GitHub] [helix] lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig

[GitBox <gi...@apache.org>]

lei-xia commented on a change in pull request #336: #334 Fix invoke rebalance by "touching" IdealState/ResourceConfig
URL: https://github.com/apache/helix/pull/336#discussion_r304025056
 
 

 ##########
 File path: helix-core/src/main/java/org/apache/helix/controller/rebalancer/util/RebalanceScheduler.java
 ##########
 @@ -138,7 +140,7 @@ public static void invokeRebalance(HelixDataAccessor accessor, String resource)
     PropertyKey key = accessor.keyBuilder().idealStates(resource);
     IdealState is = accessor.getProperty(key);
     if (is != null) {
-      if (!accessor.updateProperty(key, is)) {
+      if (!accessor.updateProperty(key, znRecord -> znRecord, is)) {
 
 Review comment:
   +1 to have a comment, otherwise it could be confusing here.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services