You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lucene.apache.org by "Michael McCandless (Commented) (JIRA)" <ji...@apache.org> on 2012/03/25 18:57:26 UTC

[jira] [Commented] (LUCENE-3581) IndexReader#isCurrent() should return true on a NRT reader if no deletes are applied and only deletes are present in IW

    [ https://issues.apache.org/jira/browse/LUCENE-3581?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13237926#comment-13237926 ] 

Michael McCandless commented on LUCENE-3581:
--------------------------------------------

This need not block 3.6.0 right?

We are returning "false" when we could return "true" from isCurrent, but this just means the app will go through the reopen when it didn't have to...?  Ie relatively minor?
                
> IndexReader#isCurrent() should return true on a NRT reader if no deletes are applied and only deletes are present in IW
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: LUCENE-3581
>                 URL: https://issues.apache.org/jira/browse/LUCENE-3581
>             Project: Lucene - Java
>          Issue Type: Bug
>    Affects Versions: 3.5, 4.0
>            Reporter: Simon Willnauer
>            Assignee: Simon Willnauer
>             Fix For: 3.6, 4.0
>
>
> I keep forgetting about this, I better open an issue. If you have a NRT reader without deletes applied it should infact return true on IR#isCurrent() if the IW only has deletes in its buffer ie. no documents where updated / added since the NRT reader was opened. Currently if there is a delete coming in we force a reopen which does nothing since deletes are not applied anyway.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org