You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by GitBox <gi...@apache.org> on 2021/04/26 15:23:37 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs
lordgamez opened a new pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on a change in pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620907627
##########
File path: extensions/script/ExecuteScript.h
##########
@@ -36,7 +36,7 @@ namespace processors {
class ExecuteScript : public core::Processor {
public:
- explicit ExecuteScript(const std::string &name, utils::Identifier uuid = utils::Identifier())
+ explicit ExecuteScript(const std::string &name, const utils::Identifier& uuid = {})
Review comment:
here as well
##########
File path: extensions/script/python/ExecutePythonProcessor.h
##########
@@ -45,7 +45,7 @@ namespace processors {
class ExecutePythonProcessor : public core::Processor {
public:
- explicit ExecutePythonProcessor(const std::string &name, utils::Identifier uuid = utils::Identifier())
+ explicit ExecutePythonProcessor(const std::string &name, const utils::Identifier& uuid = {})
Review comment:
here as well
##########
File path: extensions/script/python/PythonCreator.h
##########
@@ -43,7 +43,7 @@ namespace python {
class PythonCreator : public minifi::core::CoreComponent {
public:
- explicit PythonCreator(const std::string &name, utils::Identifier uuid = utils::Identifier())
+ explicit PythonCreator(const std::string &name, const utils::Identifier& uuid = {})
Review comment:
here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on a change in pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620907335
##########
File path: extensions/opencv/CaptureRTSPFrame.h
##########
@@ -37,7 +37,7 @@ class CaptureRTSPFrame : public core::Processor {
public:
- explicit CaptureRTSPFrame(const std::string &name, utils::Identifier uuid = utils::Identifier())
+ explicit CaptureRTSPFrame(const std::string &name, const utils::Identifier& uuid = {})
Review comment:
here as well
##########
File path: extensions/opencv/MotionDetector.h
##########
@@ -40,7 +40,7 @@ class MotionDetector : public core::Processor {
public:
- explicit MotionDetector(const std::string &name, utils::Identifier uuid = utils::Identifier())
+ explicit MotionDetector(const std::string &name, const utils::Identifier& uuid = {})
Review comment:
here as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs
Posted by GitBox <gi...@apache.org>.
lordgamez commented on a change in pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620953658
##########
File path: libminifi/include/RemoteProcessorGroupPort.h
##########
@@ -81,7 +81,7 @@ class RemoteProcessorGroupPort : public core::Processor {
/*!
* Create a new processor
*/
- RemoteProcessorGroupPort(const std::shared_ptr<io::StreamFactory> &stream_factory, std::string name, std::string url, const std::shared_ptr<Configure> &configure, utils::Identifier uuid = utils::Identifier()) // NOLINT
+ RemoteProcessorGroupPort(const std::shared_ptr<io::StreamFactory> &stream_factory, const std::string& name, std::string url, const std::shared_ptr<Configure> &configure, const utils::Identifier& uuid = {}) // NOLINT
Review comment:
Fixed in a8574d103f96566edec377a0d7e1447e33ef14b9
##########
File path: libminifi/include/core/Core.h
##########
@@ -148,7 +148,7 @@ class CoreComponent {
* Constructor that sets the name and uuid.
*/
- explicit CoreComponent(const std::string &name, const utils::Identifier& uuid = {}, const std::shared_ptr<utils::IdGenerator>& idGenerator = utils::IdGenerator::getIdGenerator())
+ explicit CoreComponent(const std::string &name, const utils::Identifier &uuid = {}, const std::shared_ptr<utils::IdGenerator>& idGenerator = utils::IdGenerator::getIdGenerator())
Review comment:
Fixed in a8574d103f96566edec377a0d7e1447e33ef14b9
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on a change in pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620906869
##########
File path: extensions/jni/JVMCreator.h
##########
@@ -40,7 +40,7 @@ namespace jni {
class JVMCreator : public minifi::core::CoreComponent {
public:
- explicit JVMCreator(const std::string &name, utils::Identifier uuid = utils::Identifier())
+ explicit JVMCreator(const std::string &name, const utils::Identifier& uuid = {})
Review comment:
inconsistent `&` placing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on a change in pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620906869
##########
File path: extensions/jni/JVMCreator.h
##########
@@ -40,7 +40,7 @@ namespace jni {
class JVMCreator : public minifi::core::CoreComponent {
public:
- explicit JVMCreator(const std::string &name, utils::Identifier uuid = utils::Identifier())
+ explicit JVMCreator(const std::string &name, const utils::Identifier& uuid = {})
Review comment:
inconsistent `&` placing in a few places (counted 23)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] arpadboda closed pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs
Posted by GitBox <gi...@apache.org>.
arpadboda closed pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] adamdebreceni commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs
Posted by GitBox <gi...@apache.org>.
adamdebreceni commented on a change in pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620943362
##########
File path: libminifi/include/core/Core.h
##########
@@ -148,7 +148,7 @@ class CoreComponent {
* Constructor that sets the name and uuid.
*/
- explicit CoreComponent(const std::string &name, const utils::Identifier& uuid = {}, const std::shared_ptr<utils::IdGenerator>& idGenerator = utils::IdGenerator::getIdGenerator())
+ explicit CoreComponent(const std::string &name, const utils::Identifier &uuid = {}, const std::shared_ptr<utils::IdGenerator>& idGenerator = utils::IdGenerator::getIdGenerator())
Review comment:
one more here
##########
File path: libminifi/include/RemoteProcessorGroupPort.h
##########
@@ -81,7 +81,7 @@ class RemoteProcessorGroupPort : public core::Processor {
/*!
* Create a new processor
*/
- RemoteProcessorGroupPort(const std::shared_ptr<io::StreamFactory> &stream_factory, std::string name, std::string url, const std::shared_ptr<Configure> &configure, utils::Identifier uuid = utils::Identifier()) // NOLINT
+ RemoteProcessorGroupPort(const std::shared_ptr<io::StreamFactory> &stream_factory, const std::string& name, std::string url, const std::shared_ptr<Configure> &configure, const utils::Identifier& uuid = {}) // NOLINT
Review comment:
one more inconsistency here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a change in pull request #1062: MINIFICPP-1502 Pass name and uuid arguments as const refs
Posted by GitBox <gi...@apache.org>.
lordgamez commented on a change in pull request #1062:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1062#discussion_r620933146
##########
File path: extensions/jni/JVMCreator.h
##########
@@ -40,7 +40,7 @@ namespace jni {
class JVMCreator : public minifi::core::CoreComponent {
public:
- explicit JVMCreator(const std::string &name, utils::Identifier uuid = utils::Identifier())
+ explicit JVMCreator(const std::string &name, const utils::Identifier& uuid = {})
Review comment:
Fixed in 986bca3bf8ae4897cf73ce1fbe6530015f79989e
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org