You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2020/07/01 02:03:20 UTC

[GitHub] [incubator-nuttx] anchao commented on a change in pull request #1331: make/version: correct the version generation

anchao commented on a change in pull request #1331:
URL: https://github.com/apache/incubator-nuttx/pull/1331#discussion_r448074650



##########
File path: tools/Makefile.unix
##########
@@ -31,7 +31,7 @@ endif
 
 # In case we cannot get version information from GIT
 
-ifneq ($(GIT_PRESENT),true)
+ifeq ($(GIT_PRESENT),)

Review comment:
       > @anchao I just tested this out of tree and it breaks again,
   
   emm...  In fact, I do not quite understand what happened on PX4 build, I would like to try it later...




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org