[jira] [Updated] (SOLR-8302) SolrResourceLoader should take a Path to its instance directory, rather than a String

["Alan Woodward (JIRA)" <ji...@apache.org>]

     [ https://issues.apache.org/jira/browse/SOLR-8302?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alan Woodward updated SOLR-8302:
--------------------------------
    Attachment: SOLR-8302.patch

Patch for trunk.  This changes the SolrResourceLoader constructors to take Path instead of String, and getInstanceDir() now returns a Path as well.  I've tried to keep the effects on everything else as limited as possible, to keep the size of the patch down.

One question is whether this should be a clean break for 5.4, or if I should add back the altered method signatures as deprecated.  SolrResourceLoader is an expert internal API, but there's a possibility that some plugins might use getInstanceDir().

> SolrResourceLoader should take a Path to its instance directory, rather than a String
> -------------------------------------------------------------------------------------
>
>                 Key: SOLR-8302
>                 URL: https://issues.apache.org/jira/browse/SOLR-8302
>             Project: Solr
>          Issue Type: Improvement
>            Reporter: Alan Woodward
>            Assignee: Alan Woodward
>         Attachments: SOLR-8302.patch
>
>
> First step of SOLR-8282.  We have a whole bunch of code that deals with loading things relative to the resource loader's instance dir.  These become a lot simpler if the instance dir is a Path.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@lucene.apache.org
For additional commands, e-mail: dev-help@lucene.apache.org