You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by GitBox <gi...@apache.org> on 2021/08/27 22:03:33 UTC
[GitHub] [arrow-cookbook] westonpace opened a new pull request #52: Use ARROW_RETURN_NOT_OK (and friends) instead of ASSERT_OK (and friends) in recipes
westonpace opened a new pull request #52:
URL: https://github.com/apache/arrow-cookbook/pull/52
Addresses #44
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] westonpace merged pull request #52: Use ARROW_RETURN_NOT_OK (and friends) instead of ASSERT_OK (and friends) in recipes
Posted by GitBox <gi...@apache.org>.
westonpace merged pull request #52:
URL: https://github.com/apache/arrow-cookbook/pull/52
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] westonpace commented on pull request #52: Use ARROW_RETURN_NOT_OK (and friends) instead of ASSERT_OK (and friends) in recipes
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #52:
URL: https://github.com/apache/arrow-cookbook/pull/52#issuecomment-1056158235
Ping @pitrou :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] lidavidm commented on pull request #52: Use ARROW_RETURN_NOT_OK (and friends) instead of ASSERT_OK (and friends) in recipes
Posted by GitBox <gi...@apache.org>.
lidavidm commented on pull request #52:
URL: https://github.com/apache/arrow-cookbook/pull/52#issuecomment-1069751921
It was @pitrou's suggestion :sweat_smile:
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] pitrou commented on a change in pull request #52: Use ARROW_RETURN_NOT_OK (and friends) instead of ASSERT_OK (and friends) in recipes
Posted by GitBox <gi...@apache.org>.
pitrou commented on a change in pull request #52:
URL: https://github.com/apache/arrow-cookbook/pull/52#discussion_r817477821
##########
File path: cpp/code/common.cc
##########
@@ -55,6 +55,17 @@ void EndRecipe(const std::string& recipe_name) {
current_recipe = "";
}
+arrow::Status EndRecipe(const std::string& recipe_name) {
+ DoEndRecipe(recipe_name);
+ return arrow::Status::OK();
Review comment:
Do you envision that `EndRecipe` may fail in later iterations of the support code?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] westonpace commented on pull request #52: Use ARROW_RETURN_NOT_OK (and friends) instead of ASSERT_OK (and friends) in recipes
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #52:
URL: https://github.com/apache/arrow-cookbook/pull/52#issuecomment-1048346049
I updated the instructions and ended up changing things a bit further to the dataset new recipes that need to share state between recipes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] westonpace commented on pull request #52: Use ARROW_RETURN_NOT_OK (and friends) instead of ASSERT_OK (and friends) in recipes
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #52:
URL: https://github.com/apache/arrow-cookbook/pull/52#issuecomment-1028689287
Thanks for the ping. I haven't had much time for cookbook work recently. I'll take a look at this one on Friday and either fix it up or close it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] westonpace commented on pull request #52: Use ARROW_RETURN_NOT_OK (and friends) instead of ASSERT_OK (and friends) in recipes
Posted by GitBox <gi...@apache.org>.
westonpace commented on pull request #52:
URL: https://github.com/apache/arrow-cookbook/pull/52#issuecomment-1069693668
I came back to this and realized that @lidavidm 's flight test offers a much better solution. We can simply move the test body into it's own method that returns a status. This avoids the complexity of "recipe collections" and, since these tests should be quite small, there is little downside. So I moved the tests to this approach instead.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] pitrou commented on pull request #52: Use ARROW_RETURN_NOT_OK (and friends) instead of ASSERT_OK (and friends) in recipes
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #52:
URL: https://github.com/apache/arrow-cookbook/pull/52#issuecomment-1027984840
Ping @westonpace
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-cookbook] pitrou commented on pull request #52: Use ARROW_RETURN_NOT_OK (and friends) instead of ASSERT_OK (and friends) in recipes
Posted by GitBox <gi...@apache.org>.
pitrou commented on pull request #52:
URL: https://github.com/apache/arrow-cookbook/pull/52#issuecomment-910198329
Can you update cpp/CONTRIBUTING.md for the recipe API changes?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org