You are viewing a plain text version of this content. The canonical link for it is here.

Posted to reviews@spark.apache.org by yanboliang <gi...@git.apache.org> on 2015/10/27 16:02:22 UTC

[GitHub] spark pull request: [SPARK-11349] [ML] Support transform string la...

GitHub user yanboliang opened a pull request:

    https://github.com/apache/spark/pull/9302

    [SPARK-11349] [ML] Support transform string label for RFormula

    Currently ```RFormula``` can only handle label with ```NumericType``` or ```BinaryType``` (cast it to ```DoubleType``` as the label of Linear Regression training), we should also support label of ```StringType``` which is needed for Logistic Regression (glm with family = "binomial"). 
    For label of ```StringType```, we should use ```StringIndexer``` to transform it to 0-based index.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/yanboliang/spark spark-11349

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/spark/pull/9302.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #9302
    
----
commit 233ce5f3f672b71c20d91b8cbe73d45d615f14f9
Author: Yanbo Liang <yb...@gmail.com>
Date:   2015-10-27T14:57:49Z

    Support transform string label for RFormula

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-11349] [ML] Support transform string la...

Posted by yanboliang <gi...@git.apache.org>.

Github user yanboliang commented on the pull request:

    https://github.com/apache/spark/pull/9302#issuecomment-151806442
  
    I think further more we should provide a param named ```family``` for ```RFormula``` to indicate the estimator/model which will be applied to the dataframe transformed by this ```RFormula``` transformer, and then we can do more strict label validation check.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-11349] [ML] Support transform string la...

Posted by mengxr <gi...@git.apache.org>.

Github user mengxr commented on a diff in the pull request:

    https://github.com/apache/spark/pull/9302#discussion_r43703873
  
    --- Diff: mllib/src/main/scala/org/apache/spark/ml/feature/RFormula.scala ---
    @@ -200,6 +200,13 @@ class RFormulaModel private[feature](
           dataset.schema(labelName).dataType match {
             case _: NumericType | BooleanType =>
               dataset.withColumn($(labelCol), dataset(labelName).cast(DoubleType))
    +        case _: StringType => {
    +          val indexer = new StringIndexer()
    --- End diff --
    
    This should not happen inside `transform`. we cannot afford one `fit` call per `transform`. We should inside the label indexer into the `RFormula.fit`instead of `RFormulaModel.transform`.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] spark pull request: [SPARK-11349] [ML] Support transform string la...

Posted by SparkQA <gi...@git.apache.org>.

Github user SparkQA commented on the pull request:

    https://github.com/apache/spark/pull/9302#issuecomment-153370734
  
    **[Test build #44925 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/44925/consoleFull)** for PR 9302 at commit [`40b9a27`](https://github.com/apache/spark/commit/40b9a27361e422fd41ea0404cd61599e4afba00c).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org