You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@avro.apache.org by "Doug Cutting (Resolved) (JIRA)" <ji...@apache.org> on 2011/10/07 21:32:29 UTC

[jira] [Resolved] (AVRO-911) remove object reuse from Java APIs

     [ https://issues.apache.org/jira/browse/AVRO-911?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Doug Cutting resolved AVRO-911.
-------------------------------

       Resolution: Won't Fix
    Fix Version/s:     (was: 1.6.0)
     Hadoop Flags:   (was: Incompatible change)

We have another way to resolve AVRO-813 without removing reuse.  Several folks seem to want to keep reuse in Avro's Java API's, so I will resolve this as "Won't Fix".
                
> remove object reuse from Java APIs
> ----------------------------------
>
>                 Key: AVRO-911
>                 URL: https://issues.apache.org/jira/browse/AVRO-911
>             Project: Avro
>          Issue Type: Improvement
>          Components: java
>            Reporter: Doug Cutting
>            Assignee: Doug Cutting
>         Attachments: perf-reuse.patch
>
>
> Avro's Java APIs were designed to permit object reuse when reading with the assumption that would provide performance advantages.  In particular, the old parameter in DatumReader<T>.read(T old, Decoder), the Utf8 class, and the GenericArray.peek() method were all designed for this purpose.  But I am unable to see significant performance improvements when objects are reused.  I tried modifying Perf.java's GenericTest to reuse records, and its StringTest to not reuse Utf8 instances and, in both cases, performance is not substantially altered.
> If we were to remove these then issues such as AVRO-803 would disappear.  Always using java.lang.String instead of Utf8 would remove a lot of user confusion. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira