You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@linkis.apache.org by GitBox <gi...@apache.org> on 2022/07/12 05:39:23 UTC
[GitHub] [incubator-linkis] jackxu2011 opened a new pull request, #2458: Opt format code
jackxu2011 opened a new pull request, #2458:
URL: https://github.com/apache/incubator-linkis/pull/2458
### What is the purpose of the change
refactor some code
ref to #1475
### Brief change log
(for example:)
- format some code
### Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
### Does this pull request potentially affect one of the following parts:
- Dependencies (does it add or upgrade a dependency): no
- Anything that affects deployment: no
- The MGS(Microservice Governance Services), i.e., Spring Cloud Gateway, OpenFeign, Eureka.: no
### Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? (not applicable / docs / JavaDocs / not documented)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong merged pull request #2458: Opt format code
Posted by GitBox <gi...@apache.org>.
peacewong merged PR #2458:
URL: https://github.com/apache/incubator-linkis/pull/2458
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2458: Opt format code
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2458:
URL: https://github.com/apache/incubator-linkis/pull/2458#discussion_r918953442
##########
linkis-commons/linkis-storage/pom.xml:
##########
@@ -36,7 +36,6 @@
<groupId>org.apache.linkis</groupId>
<artifactId>linkis-common</artifactId>
<version>${linkis.version}</version>
- <scope>provided</scope>
Review Comment:
the common and storage are all the shared module, the provided scope is not need. and the storage miss the commons-lang3 jar, which is import by runtime scope by other jars, so change the scope of linkis-common's scope to fix the dependency miss.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] jackxu2011 commented on a diff in pull request #2458: Opt format code
Posted by GitBox <gi...@apache.org>.
jackxu2011 commented on code in PR #2458:
URL: https://github.com/apache/incubator-linkis/pull/2458#discussion_r920714777
##########
linkis-orchestrator/linkis-computation-orchestrator/src/main/scala/org/apache/linkis/orchestrator/computation/monitor/EngineConnMonitor.scala:
##########
@@ -138,8 +138,6 @@ object EngineConnMonitor extends Logging {
endJobByEngineInstance(status._1)
}
}
- case o: Any =>
- logger.error(s"Status of engine ${status._1.toString} is ${status._2}")
Review Comment:
the NodeExistStatus is a enum, all the above case coverd all branch. And the case o: Any block is't reachable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] peacewong commented on a diff in pull request #2458: Opt format code
Posted by GitBox <gi...@apache.org>.
peacewong commented on code in PR #2458:
URL: https://github.com/apache/incubator-linkis/pull/2458#discussion_r918878779
##########
linkis-commons/linkis-storage/pom.xml:
##########
@@ -36,7 +36,6 @@
<groupId>org.apache.linkis</groupId>
<artifactId>linkis-common</artifactId>
<version>${linkis.version}</version>
- <scope>provided</scope>
Review Comment:
Why remove provided?
##########
linkis-orchestrator/linkis-computation-orchestrator/src/main/scala/org/apache/linkis/orchestrator/computation/monitor/EngineConnMonitor.scala:
##########
@@ -138,8 +138,6 @@ object EngineConnMonitor extends Logging {
endJobByEngineInstance(status._1)
}
}
- case o: Any =>
- logger.error(s"Status of engine ${status._1.toString} is ${status._2}")
Review Comment:
should update to case _: log
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org
[GitHub] [incubator-linkis] codecov[bot] commented on pull request #2458: Opt format code
Posted by GitBox <gi...@apache.org>.
codecov[bot] commented on PR #2458:
URL: https://github.com/apache/incubator-linkis/pull/2458#issuecomment-1181349952
# [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2458?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#2458](https://codecov.io/gh/apache/incubator-linkis/pull/2458?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (0c3f00c) into [dev-1.2.0](https://codecov.io/gh/apache/incubator-linkis/commit/4964cddb1f76082a80eb0f4a58d09397c141d7f8?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4964cdd) will **increase** coverage by `0.01%`.
> The diff coverage is `0.00%`.
```diff
@@ Coverage Diff @@
## dev-1.2.0 #2458 +/- ##
===============================================
+ Coverage 16.59% 16.61% +0.01%
- Complexity 1103 1104 +1
===============================================
Files 636 636
Lines 19520 19520
Branches 2769 2769
===============================================
+ Hits 3240 3243 +3
+ Misses 15843 15842 -1
+ Partials 437 435 -2
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-linkis/pull/2458?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...che/linkis/rpc/message/method/MessageExecutor.java](https://codecov.io/gh/apache/incubator-linkis/pull/2458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXJwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL3JwYy9tZXNzYWdlL21ldGhvZC9NZXNzYWdlRXhlY3V0b3IuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...inkis/rpc/message/method/MethodExecuteWrapper.java](https://codecov.io/gh/apache/incubator-linkis/pull/2458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXJwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL3JwYy9tZXNzYWdlL21ldGhvZC9NZXRob2RFeGVjdXRlV3JhcHBlci5qYXZh) | `30.76% <ø> (ø)` | |
| [...is/rpc/message/utils/LoadBalancerOptionsUtils.java](https://codecov.io/gh/apache/incubator-linkis/pull/2458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXJwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL3JwYy9tZXNzYWdlL3V0aWxzL0xvYWRCYWxhbmNlck9wdGlvbnNVdGlscy5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...linkis/rpc/serializer/ProtostuffSerializeUtil.java](https://codecov.io/gh/apache/incubator-linkis/pull/2458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXJwYy9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvbGlua2lzL3JwYy9zZXJpYWxpemVyL1Byb3Rvc3R1ZmZTZXJpYWxpemVVdGlsLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/linkis/rpc/conf/RPCConfiguration.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXJwYy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9ycGMvY29uZi9SUENDb25maWd1cmF0aW9uLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...pache/linkis/rpc/conf/RPCSpringConfiguration.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXJwYy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9ycGMvY29uZi9SUENTcHJpbmdDb25maWd1cmF0aW9uLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...s/rpc/sender/eureka/EurekaClientRefreshUtils.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXJwYy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9ycGMvc2VuZGVyL2V1cmVrYS9FdXJla2FDbGllbnRSZWZyZXNoVXRpbHMuc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| [...inkis/rpc/transform/JavaCollectionSerializer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXJwYy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9ycGMvdHJhbnNmb3JtL0phdmFDb2xsZWN0aW9uU2VyaWFsaXplci5zY2FsYQ==) | `0.00% <0.00%> (ø)` | |
| [.../org/apache/linkis/rpc/transform/RPCConsumer.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXJwYy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9ycGMvdHJhbnNmb3JtL1JQQ0NvbnN1bWVyLnNjYWxh) | `0.00% <0.00%> (ø)` | |
| [...a/org/apache/linkis/rpc/transform/RPCProduct.scala](https://codecov.io/gh/apache/incubator-linkis/pull/2458/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-bGlua2lzLWNvbW1vbnMvbGlua2lzLXJwYy9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2xpbmtpcy9ycGMvdHJhbnNmb3JtL1JQQ1Byb2R1Y3Quc2NhbGE=) | `0.00% <0.00%> (ø)` | |
| ... and [3 more](https://codecov.io/gh/apache/incubator-linkis/pull/2458/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2458?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-linkis/pull/2458?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [4964cdd...0c3f00c](https://codecov.io/gh/apache/incubator-linkis/pull/2458?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@linkis.apache.org
For additional commands, e-mail: notifications-help@linkis.apache.org