You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@maven.apache.org by ti...@apache.org on 2015/05/04 00:07:30 UTC

[3/3] maven-surefire git commit: Rework after review

Rework after review


Project: http://git-wip-us.apache.org/repos/asf/maven-surefire/repo
Commit: http://git-wip-us.apache.org/repos/asf/maven-surefire/commit/c02be388
Tree: http://git-wip-us.apache.org/repos/asf/maven-surefire/tree/c02be388
Diff: http://git-wip-us.apache.org/repos/asf/maven-surefire/diff/c02be388

Branch: refs/heads/master
Commit: c02be388b6e5110982a6a9e238199c298119c3fb
Parents: 464a1cc
Author: Julien Herr <ju...@alcatel-lucent.com>
Authored: Sun May 3 22:45:32 2015 +0200
Committer: Tibor17 <ti...@lycos.com>
Committed: Sun May 3 23:44:33 2015 +0200

----------------------------------------------------------------------
 .../maven/plugin/surefire/AbstractSurefireMojo.java  | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/maven-surefire/blob/c02be388/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
----------------------------------------------------------------------
diff --git a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
index dd49f56..33b90bd 100644
--- a/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
+++ b/maven-surefire-common/src/main/java/org/apache/maven/plugin/surefire/AbstractSurefireMojo.java
@@ -1723,6 +1723,8 @@ public abstract class AbstractSurefireMojo
         throws MojoExecutionException
     {
         Artifact artifact = getProjectArtifactMap().get( getTestNGArtifactName() );
+        Artifact projectArtifact = project.getArtifact();
+        String projectArtifactName = projectArtifact.getGroupId() + ":" + projectArtifact.getArtifactId();
 
         if ( artifact != null )
         {
@@ -1734,11 +1736,11 @@ public abstract class AbstractSurefireMojo
                         + artifact.getVersion() );
             }
         }
-        else if ( getTestNGArtifactName().equals(
-            project.getArtifact().getGroupId() + ":" + project.getArtifact().getArtifactId() ) )
+        else if ( projectArtifactName.equals( getTestNGArtifactName() ) )
         {
-            return project.getArtifact();
+            artifact = projectArtifact;
         }
+
         return artifact;
 
     }
@@ -1758,11 +1760,12 @@ public abstract class AbstractSurefireMojo
     private Artifact getJunitArtifact()
     {
         Artifact artifact = getProjectArtifactMap().get( getJunitArtifactName() );
+        Artifact projectArtifact = project.getArtifact();
+        String projectArtifactName = projectArtifact.getGroupId() + ":" + projectArtifact.getArtifactId();
 
-        if ( artifact == null && getJunitArtifactName().equals(
-            project.getArtifact().getGroupId() + ":" + project.getArtifact().getArtifactId() ) )
+        if ( artifact == null && projectArtifactName.equals( getJunitArtifactName() ) )
         {
-            return project.getArtifact();
+            artifact = projectArtifact;
         }
 
         return artifact;