You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Rayees Namathponnan <ra...@citrix.com> on 2013/06/16 02:19:17 UTC
Review Request: Fix test case issue reported in CLOUDSTACK-3020
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11897/
-----------------------------------------------------------
Review request for cloudstack and tom pierce.
Description
-------
Fixing test case assert issue with TestInstanceNameFlagTrue.test_02_instancename_from_default_configuration
Diffs
-----
Diff: https://reviews.apache.org/r/11897/diff/
Testing
-------
Tested
Thanks,
Rayees Namathponnan
Re: Review Request: Fix test case issue reported in CLOUDSTACK-3020
Posted by Rayees Namathponnan <ra...@citrix.com>.
> On June 16, 2013, 5:55 a.m., Prasanna Santhanam wrote:
> > Doesn't the displayname become the uuid hence the id when no custom instance name is given? It seems the assertEqual is correct, but the assertion message should be
> > "DisplayName should be UUID when no custom hostname is provided"
> >
No, if you are not giving name during vm creation, UUID will set for Name and Display name will be blank.
- Rayees
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11897/#review21954
-----------------------------------------------------------
On June 16, 2013, 5:56 a.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11897/
> -----------------------------------------------------------
>
> (Updated June 16, 2013, 5:56 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> Fixing test case assert issue with TestInstanceNameFlagTrue.test_02_instancename_from_default_configuration
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/11897/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Rayees Namathponnan
>
>
Re: Review Request: Fix test case issue reported in CLOUDSTACK-3020
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11897/#review21954
-----------------------------------------------------------
Doesn't the displayname become the uuid hence the id when no custom instance name is given? It seems the assertEqual is correct, but the assertion message should be
"DisplayName should be UUID when no custom hostname is provided"
- Prasanna Santhanam
On June 16, 2013, 12:19 a.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11897/
> -----------------------------------------------------------
>
> (Updated June 16, 2013, 12:19 a.m.)
>
>
> Review request for cloudstack and tom pierce.
>
>
> Description
> -------
>
> Fixing test case assert issue with TestInstanceNameFlagTrue.test_02_instancename_from_default_configuration
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/11897/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Rayees Namathponnan
>
>
Re: Review Request: Fix test case issue reported in CLOUDSTACK-3020
Posted by ASF Subversion and Git Services <as...@urd.zones.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11897/#review21965
-----------------------------------------------------------
Commit bf0265d21d77dbc28bc61f46c535ca75b727d115 in branch refs/heads/master from rayeesn
[ https://git-wip-us.apache.org/repos/asf?p=cloudstack.git;h=bf0265d ]
CLOUDSTACK-3020: Fix assert error
If you do not give a name during vm creation, UUID will be set for Name
and Display name will be blank.
Signed-off-by: Prasanna Santhanam <ts...@apache.org>
- ASF Subversion and Git Services
On June 16, 2013, 5:56 a.m., Rayees Namathponnan wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/11897/
> -----------------------------------------------------------
>
> (Updated June 16, 2013, 5:56 a.m.)
>
>
> Review request for cloudstack and Prasanna Santhanam.
>
>
> Description
> -------
>
> Fixing test case assert issue with TestInstanceNameFlagTrue.test_02_instancename_from_default_configuration
>
>
> Diffs
> -----
>
>
> Diff: https://reviews.apache.org/r/11897/diff/
>
>
> Testing
> -------
>
> Tested
>
>
> Thanks,
>
> Rayees Namathponnan
>
>
Re: Review Request: Fix test case issue reported in CLOUDSTACK-3020
Posted by Prasanna Santhanam <ts...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/11897/
-----------------------------------------------------------
(Updated June 16, 2013, 5:56 a.m.)
Review request for cloudstack and Prasanna Santhanam.
Changes
-------
correcting reviewer
Description
-------
Fixing test case assert issue with TestInstanceNameFlagTrue.test_02_instancename_from_default_configuration
Diffs
-----
Diff: https://reviews.apache.org/r/11897/diff/
Testing
-------
Tested
Thanks,
Rayees Namathponnan