You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Alexey Serbin (Code Review)" <ge...@cloudera.org> on 2018/08/28 01:24:41 UTC
[kudu-CR] [build] add -DLEAK SANITIZER to compilation flags
Alexey Serbin has uploaded this change for review. ( http://gerrit.cloudera.org:8080/11340
Change subject: [build] add -DLEAK_SANITIZER to compilation flags
......................................................................
[build] add -DLEAK_SANITIZER to compilation flags
To enable __lsan_default_suppressions() defined in
src/kudu/util/sanitizer_options.cc, it's necessary to have
LEAK_SANITIZER macro enabled during the compilation.
This patch fixes negotiation-test failures in ASAN builds.
This is a follow-up for a8d088e11b8b901a91e4820dcfdca9537a1e801a.
Change-Id: Ie8caeaa080b93f67768d3d2251c7a366390a48f9
---
M CMakeLists.txt
1 file changed, 3 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11340/1
--
To view, visit http://gerrit.cloudera.org:8080/11340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: Ie8caeaa080b93f67768d3d2251c7a366390a48f9
Gerrit-Change-Number: 11340
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
[kudu-CR] [build] add -D{LEAK,UNDEFINED} SANITIZER
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/11340 )
Change subject: [build] add -D{LEAK,UNDEFINED}_SANITIZER
......................................................................
[build] add -D{LEAK,UNDEFINED}_SANITIZER
To enable __lsan_default_suppressions() defined in
src/kudu/util/sanitizer_options.cc, it's necessary to have
LEAK_SANITIZER macro enabled during the compilation.
Also, defined UNDEFINED_SANITIZER macro to compile-in
__ubsan_default_options() as well.
This patch fixes negotiation-test failures in ASAN builds.
This is a follow-up for a8d088e11b8b901a91e4820dcfdca9537a1e801a.
Change-Id: Ie8caeaa080b93f67768d3d2251c7a366390a48f9
Reviewed-on: http://gerrit.cloudera.org:8080/11340
Reviewed-by: Grant Henke <gr...@apache.org>
Tested-by: Alexey Serbin <as...@cloudera.com>
---
M CMakeLists.txt
1 file changed, 4 insertions(+), 2 deletions(-)
Approvals:
Grant Henke: Looks good to me, approved
Alexey Serbin: Verified
--
To view, visit http://gerrit.cloudera.org:8080/11340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: Ie8caeaa080b93f67768d3d2251c7a366390a48f9
Gerrit-Change-Number: 11340
Gerrit-PatchSet: 3
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
[kudu-CR] [build] add -D{LEAK,UNDEFINED} SANITIZER
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Hello Kudu Jenkins, Andrew Wong, Adar Dembo, Grant Henke,
I'd like you to reexamine a change. Please visit
http://gerrit.cloudera.org:8080/11340
to look at the new patch set (#2).
Change subject: [build] add -D{LEAK,UNDEFINED}_SANITIZER
......................................................................
[build] add -D{LEAK,UNDEFINED}_SANITIZER
To enable __lsan_default_suppressions() defined in
src/kudu/util/sanitizer_options.cc, it's necessary to have
LEAK_SANITIZER macro enabled during the compilation.
Also, defined UNDEFINED_SANITIZER macro to compile-in
__ubsan_default_options() as well.
This patch fixes negotiation-test failures in ASAN builds.
This is a follow-up for a8d088e11b8b901a91e4820dcfdca9537a1e801a.
Change-Id: Ie8caeaa080b93f67768d3d2251c7a366390a48f9
---
M CMakeLists.txt
1 file changed, 4 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/40/11340/2
--
To view, visit http://gerrit.cloudera.org:8080/11340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: Ie8caeaa080b93f67768d3d2251c7a366390a48f9
Gerrit-Change-Number: 11340
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
[kudu-CR] [build] add -D{LEAK,UNDEFINED} SANITIZER
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11340 )
Change subject: [build] add -D{LEAK,UNDEFINED}_SANITIZER
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11340/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/11340/1/CMakeLists.txt@353
PS1, Line 353: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=undefined,integer")
> Do you mind adding -DUNDEFINED_SANITIZER here? It's not causing problems no
Good catch! Done.
--
To view, visit http://gerrit.cloudera.org:8080/11340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8caeaa080b93f67768d3d2251c7a366390a48f9
Gerrit-Change-Number: 11340
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 28 Aug 2018 02:47:02 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] add -D{LEAK,UNDEFINED} SANITIZER
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/11340 )
Change subject: [build] add -D{LEAK,UNDEFINED}_SANITIZER
......................................................................
Patch Set 2: Verified+1
Known flake in EnableKudu1097AndDownTS/MoveTabletParamTest.Test
--
To view, visit http://gerrit.cloudera.org:8080/11340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8caeaa080b93f67768d3d2251c7a366390a48f9
Gerrit-Change-Number: 11340
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Comment-Date: Tue, 28 Aug 2018 03:08:57 +0000
Gerrit-HasComments: No
[kudu-CR] [build] add -D{LEAK,UNDEFINED} SANITIZER
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11340 )
Change subject: [build] add -D{LEAK,UNDEFINED}_SANITIZER
......................................................................
Patch Set 2: Code-Review+2
--
To view, visit http://gerrit.cloudera.org:8080/11340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8caeaa080b93f67768d3d2251c7a366390a48f9
Gerrit-Change-Number: 11340
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 28 Aug 2018 02:47:06 +0000
Gerrit-HasComments: No
[kudu-CR] [build] add -DLEAK SANITIZER to compilation flags
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11340 )
Change subject: [build] add -DLEAK_SANITIZER to compilation flags
......................................................................
Patch Set 1:
Thank you for fixing this.
For reference we always enabled these via environment in the past and now need to explicitly use these flags to trigger the options.
See here for the old way: https://github.com/apache/kudu/blob/branch-1.7.x/build-support/run-test.sh#L130-L132
I will look into why this only fails on el6 and not el7 as that isn't clear to me.
--
To view, visit http://gerrit.cloudera.org:8080/11340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8caeaa080b93f67768d3d2251c7a366390a48f9
Gerrit-Change-Number: 11340
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 28 Aug 2018 01:44:19 +0000
Gerrit-HasComments: No
[kudu-CR] [build] add -DLEAK SANITIZER to compilation flags
Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/11340 )
Change subject: [build] add -DLEAK_SANITIZER to compilation flags
......................................................................
Patch Set 1: Code-Review+1
Ran this on a centos 6.6 machine (on which negotiation-test would previously hit KUDU-2555). Now the output is:
-----------------------------------------------------
Suppressions used:
count bytes template
1 1 krb5_authdata_import_attributes
-----------------------------------------------------
--
To view, visit http://gerrit.cloudera.org:8080/11340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8caeaa080b93f67768d3d2251c7a366390a48f9
Gerrit-Change-Number: 11340
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 28 Aug 2018 01:39:47 +0000
Gerrit-HasComments: No
[kudu-CR] [build] add -DLEAK SANITIZER to compilation flags
Posted by "Grant Henke (Code Review)" <ge...@cloudera.org>.
Grant Henke has posted comments on this change. ( http://gerrit.cloudera.org:8080/11340 )
Change subject: [build] add -DLEAK_SANITIZER to compilation flags
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/11340/1/CMakeLists.txt
File CMakeLists.txt:
http://gerrit.cloudera.org:8080/#/c/11340/1/CMakeLists.txt@353
PS1, Line 353: set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -fsanitize=undefined,integer")
Do you mind adding -DUNDEFINED_SANITIZER here? It's not causing problems now because we don't use suppressions, but it could in the future. I can also do it in a separate patch if you like.
--
To view, visit http://gerrit.cloudera.org:8080/11340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: Ie8caeaa080b93f67768d3d2251c7a366390a48f9
Gerrit-Change-Number: 11340
Gerrit-PatchSet: 1
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Comment-Date: Tue, 28 Aug 2018 01:48:50 +0000
Gerrit-HasComments: Yes
[kudu-CR] [build] add -D{LEAK,UNDEFINED} SANITIZER
Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has removed Kudu Jenkins from this change. ( http://gerrit.cloudera.org:8080/11340 )
Change subject: [build] add -D{LEAK,UNDEFINED}_SANITIZER
......................................................................
Removed reviewer Kudu Jenkins with the following votes:
* Verified-1 by Kudu Jenkins (120)
--
To view, visit http://gerrit.cloudera.org:8080/11340
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteReviewer
Gerrit-Change-Id: Ie8caeaa080b93f67768d3d2251c7a366390a48f9
Gerrit-Change-Number: 11340
Gerrit-PatchSet: 2
Gerrit-Owner: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Grant Henke <gr...@apache.org>