You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ri...@apache.org on 2009/08/13 13:58:38 UTC
svn commit: r803851 -
/qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/logging/BrokerLoggingTest.java
Author: ritchiem
Date: Thu Aug 13 11:58:38 2009
New Revision: 803851
URL: http://svn.apache.org/viewvc?rev=803851&view=rev
Log:
QPID-2002: BLT should not be monitoring the qpid.log file it needs to monitor standard out to validate that the correct BRK-1007 log4j configuration messages is provided. So reverted change to monitor qpid.log and refined comment
Modified:
qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/logging/BrokerLoggingTest.java
Modified: qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/logging/BrokerLoggingTest.java
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/logging/BrokerLoggingTest.java?rev=803851&r1=803850&r2=803851&view=diff
==============================================================================
--- qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/logging/BrokerLoggingTest.java (original)
+++ qpid/trunk/qpid/java/systests/src/main/java/org/apache/qpid/server/logging/BrokerLoggingTest.java Thu Aug 13 11:58:38 2009
@@ -149,24 +149,23 @@
{
String TESTID = "BRK-1007";
-// _monitor = new LogMonitor(new File(System.getProperty("QPID_WORK") + "/log/qpid.log"));
-
//Remove test Log4j config from the commandline
_broker = _broker.substring(0, _broker.indexOf("-l"));
- // As a result we will pick up the broker default and will right
+ // As a result of removing the test log4j config
+ // we will pick up the broker default and will write
// data to the standard qpid.log file. Which means that the start
- // broker process will not be monitoring the right file for startup.
+ // broker process will not be monitoring the right file for startup
+ // messages. Therefore:
- // Set the broker commit ready string to check for the _log4j default
+ // Set the broker.ready string to check for the _log4j default that
+ // is still present on standard out.
System.setProperty(BROKER_READY, "Qpid Broker Ready");
startBroker();
- // Now we can create the monitor on the qpid.log that is defined in
- // the default log4j configuration
- _monitor = new LogMonitor(new File(System.getProperty("QPID_WORK") +
- "/log/qpid.log"));
+ // Now we can create the monitor as _outputFile will now be defined
+ _monitor = new LogMonitor(_outputFile);
// Ensure broker has fully started up.
getConnection();
---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project: http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org