You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2022/01/19 09:18:44 UTC

[GitHub] [incubator-nuttx] pkarashchenko opened a new pull request #5274: tools: add option to reuse boards common files for custom boards

pkarashchenko opened a new pull request #5274:
URL: https://github.com/apache/incubator-nuttx/pull/5274


   ## Summary
   I'm having a custom board configuration, but still would like to use common code for boards with the same architecture. Add option to reuse boards common files for custom boards
   
   ## Impact
   None
   
   ## Testing
   Pass CI
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5274: tools: add option to reuse boards common files for custom boards

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #5274:
URL: https://github.com/apache/incubator-nuttx/pull/5274#issuecomment-1016268143


   > > The custom boards can have their own common folder.  How would this work in that case?
   > 
   > The NuttX board arch common is used only if custom board common is not there. Please see one line above
   
   I see now, sorry.
   One thing to not here is that if one is using custom boards at some point a custom device driver can be used.  In this case, it will either go to each custom boards' source folder, or the common custom folder needs to be created.
   I think however that copying the in-tree one would be straightforward and doesn't need any configuration/modification.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5274: tools: add option to reuse boards common files for custom boards

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5274:
URL: https://github.com/apache/incubator-nuttx/pull/5274#issuecomment-1016271978


   > > > The custom boards can have their own common folder.  How would this work in that case?
   > > 
   > > The NuttX board arch common is used only if custom board common is not there. Please see one line above
   > 
   > I see now, sorry.
   > One thing to not here is that if one is using custom boards at some point a custom device driver can be used.  In this case, it will either go to each custom boards' source folder, or the common custom folder needs to be created.
   > I think however that copying the in-tree one would be straightforward and doesn't need any configuration/modification.
   
   Yes. Exactly. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] pkarashchenko merged pull request #5274: tools: add option to reuse boards common files for custom boards

Posted by GitBox <gi...@apache.org>.
pkarashchenko merged pull request #5274:
URL: https://github.com/apache/incubator-nuttx/pull/5274


   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] pkarashchenko commented on pull request #5274: tools: add option to reuse boards common files for custom boards

Posted by GitBox <gi...@apache.org>.
pkarashchenko commented on pull request #5274:
URL: https://github.com/apache/incubator-nuttx/pull/5274#issuecomment-1016258759


   > The custom boards can have their own common folder.  How would this work in that case?
   
   The NuttX board arch common is used only if custom board common is not there. Please see one line above


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [incubator-nuttx] Ouss4 commented on pull request #5274: tools: add option to reuse boards common files for custom boards

Posted by GitBox <gi...@apache.org>.
Ouss4 commented on pull request #5274:
URL: https://github.com/apache/incubator-nuttx/pull/5274#issuecomment-1016256741


   The custom boards can have their own common folder.  How would this work in that case?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@nuttx.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org