[GitHub] [pulsar] eolivelli commented on a diff in pull request #20647: [fix][broker] Fix the publish latency spike from the contention of MessageDeduplication

["eolivelli (via GitHub)" <gi...@apache.org>]

eolivelli commented on code in PR #20647:
URL: https://github.com/apache/pulsar/pull/20647#discussion_r1241767592


##########
pulsar-broker/src/main/java/org/apache/pulsar/broker/service/persistent/MessageDeduplication.java:
##########
@@ -455,23 +455,17 @@ public synchronized void producerRemoved(String producerName) {
     public synchronized void purgeInactiveProducers() {

Review Comment:
   do we need to keep this 'synchronized' ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pulsar.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org