You are viewing a plain text version of this content. The canonical link for it is here.

Posted to oak-issues@jackrabbit.apache.org by "Marcel Reutegger (Jira)" <ji...@apache.org> on 2019/12/12 08:36:00 UTC

[jira] [Commented] (OAK-5787) BlobStore should be AutoCloseable

    [ https://issues.apache.org/jira/browse/OAK-5787?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16994385#comment-16994385 ] 

Marcel Reutegger commented on OAK-5787:
---------------------------------------

Looks good to me.

> BlobStore should be AutoCloseable
> ---------------------------------
>
>                 Key: OAK-5787
>                 URL: https://issues.apache.org/jira/browse/OAK-5787
>             Project: Jackrabbit Oak
>          Issue Type: Improvement
>          Components: blob
>            Reporter: Julian Reschke
>            Assignee: Julian Reschke
>            Priority: Minor
>             Fix For: 1.22.0
>
>         Attachments: OAK-5787.diff
>
>
> {{DocumentNodeStore}} currently calls {{close()}} if the blob store instance implements {{Closeable}}.
> This has led to problems where wrapper implementations did not implement it, and thus the actual blob store instance wasn't properly shut down.
> Proposal: make {{BlobStore}} extend {{Closeable}} and get rid of all {{instanceof}} checks.
> [~thomasm] [~amitjain] - feedback appreciated.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)