[GitHub] [yunikorn-core] manirajv06 commented on a diff in pull request #638: [YUNIKORN-1959] add check for maxapplications and maxresources

["manirajv06 (via GitHub)" <gi...@apache.org>]

manirajv06 commented on code in PR #638:
URL: https://github.com/apache/yunikorn-core/pull/638#discussion_r1317414034


##########
pkg/common/configs/configvalidator.go:
##########
@@ -509,19 +509,21 @@ func checkLimit(limit Limit, existedUserName map[string]bool, existedGroupName m
 				zap.Error(err))
 			return err
 		}
+		if resources.IsZero(limitResource) {
+			return fmt.Errorf("invalid MaxResources in '%s' limit, all resource limits are zero", limit.Limit)

Review Comment:
   invalid MaxResources in '%s' limit, all resource limits are zero ->
   MaxResources is zero in '%s' limit, all resource types are zero
   



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@yunikorn.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org