[GitHub] [druid] imply-cheddar commented on a diff in pull request #13051: improve nested column serializer

[GitBox <gi...@apache.org>]

imply-cheddar commented on code in PR #13051:
URL: https://github.com/apache/druid/pull/13051#discussion_r965460448


##########
processing/src/main/java/org/apache/druid/segment/nested/NestedDataColumnSerializer.java:
##########
@@ -398,17 +405,12 @@ void openColumnSerializer(String field, SegmentWriteOutMedium medium, int maxId)
       encodedValueSerializer.open();
     }
 
-    void serializeRow(int globalId, int localId) throws IOException
-    {
-      encodedValueSerializer.addValue(localId);
-    }
-
     long getSerializedColumnSize() throws IOException
     {
       return Integer.BYTES + Integer.BYTES + encodedValueSerializer.getSerializedSize();
     }
 
-    public void open() throws IOException
+    public void open(String field) throws IOException

Review Comment:
   This parameter appears to not be getting used?



##########
processing/src/main/java/org/apache/druid/segment/nested/NestedDataColumnSerializer.java:
##########
@@ -551,12 +552,12 @@ int lookupGlobalId(Long value)
     }
 
     @Override
-    void openColumnSerializer(String field, SegmentWriteOutMedium medium, int maxId) throws IOException
+    public void open(String field) throws IOException

Review Comment:
   Just from looking at the diff, I'm a bit lost as to why all of these parameters were able to be eliminated...  I think it's because I've lost track of which class I'm looking at.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org