You are viewing a plain text version of this content. The canonical link for it is here.
Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2020/10/19 04:10:14 UTC

[GitHub] [kafka] jackyoh opened a new pull request #9452: MINOR: Remove unnecessary code in the ConnectHeader class

jackyoh opened a new pull request #9452:
URL: https://github.com/apache/kafka/pull/9452


   ```this.schemaAndValue``` is always not null. So ```assert this.schemaAndValue != null;``` is unnecessary code. 
   
   ### Committer Checklist (excluded from commit message)
   - [ ] Verify design and implementation 
   - [ ] Verify test coverage and CI build status
   - [ ] Verify documentation (including upgrade notes)
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jackyoh commented on pull request #9452: MINOR: Remove unnecessary code in the ConnectHeader class

Posted by GitBox <gi...@apache.org>.
jackyoh commented on pull request #9452:
URL: https://github.com/apache/kafka/pull/9452#issuecomment-712562825


   > @jackyoh Could you rebase PR to trigger QA?
   
   OK, I am going to rebase PR. Thank you!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 merged pull request #9452: MINOR: Remove unnecessary code in the ConnectHeader class

Posted by GitBox <gi...@apache.org>.
chia7712 merged pull request #9452:
URL: https://github.com/apache/kafka/pull/9452


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #9452: MINOR: Remove unnecessary code in the ConnectHeader class

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9452:
URL: https://github.com/apache/kafka/pull/9452#issuecomment-712555936


   ok to test


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #9452: MINOR: Remove unnecessary code in the ConnectHeader class

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9452:
URL: https://github.com/apache/kafka/pull/9452#issuecomment-712556303


   @jackyoh Could you rebase PR to trigger QA?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] jackyoh commented on pull request #9452: MINOR: Remove unnecessary code in the ConnectHeader class

Posted by GitBox <gi...@apache.org>.
jackyoh commented on pull request #9452:
URL: https://github.com/apache/kafka/pull/9452#issuecomment-712632212


   @chia7712 Thank you for the reviews.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #9452: MINOR: Remove unnecessary code in the ConnectHeader class

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9452:
URL: https://github.com/apache/kafka/pull/9452#issuecomment-712612177


   @jackyoh Thanks for this contribution. merge to trunk


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [kafka] chia7712 commented on pull request #9452: MINOR: Remove unnecessary code in the ConnectHeader class

Posted by GitBox <gi...@apache.org>.
chia7712 commented on pull request #9452:
URL: https://github.com/apache/kafka/pull/9452#issuecomment-712611316


   ```
   org.apache.kafka.streams.processor.internals.StateDirectoryTest.shouldCleanupObsoleteStateDirectoriesOnlyOnce
   ```
   
   it is flaky and related to https://github.com/apache/kafka/pull/9373#issuecomment-712582389


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org