[jira] [Commented] (FLINK-6760) Fix OverWindowTest alias test error

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/FLINK-6760?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16028243#comment-16028243 ] 

ASF GitHub Bot commented on FLINK-6760:
---------------------------------------

GitHub user sunjincheng121 opened a pull request:

    https://github.com/apache/flink/pull/4007

    [FLINK-6760][table]Fix OverWindowTest alias test error

    - [x] General
      - The pull request references the related JIRA issue ("[FLINK-6760][table]Fix OverWindowTest alias test error")
      - The pull request addresses only one issue
      - Each commit in the PR has a meaningful commit message (including the JIRA id)
    
    - [ ] Documentation
      - Documentation has been added for new functionality
      - Old documentation affected by the pull request has been updated
      - JavaDoc for public methods has been added
    
    - [ ] Tests & Build
      - Functionality added by the pull request is covered by tests
      - `mvn clean verify` has been executed successfully locally or a Travis build has passed


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sunjincheng121/flink FLINK-6760-PR

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/4007.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4007
    
----

----


> Fix OverWindowTest alias test error
> -----------------------------------
>
>                 Key: FLINK-6760
>                 URL: https://issues.apache.org/jira/browse/FLINK-6760
>             Project: Flink
>          Issue Type: Sub-task
>          Components: Table API & SQL
>    Affects Versions: 1.3.0
>            Reporter: sunjincheng
>            Assignee: sunjincheng
>
> For Sql:
> {code}
> val sql = "SELECT c, count(a) OVER (ORDER BY proctime ROWS BETWEEN 2 preceding AND CURRENT ROW) as cnt1 CURRENT ROW from MyTable"
> {code}
> The alias `cnt1` The alias did not take effect when we generated the plan string.  But we can using the alias in outer layer query, for example:
> {code}
> val sql = "SELECT cnt1 from (SELECT c, count(a) OVER (ORDER BY proctime ROWS BETWEEN 2 preceding AND CURRENT ROW) as cnt1 CURRENT ROW from MyTable)"
> {code}
> So in this JIRA. we just fix the test case for 1.3 release. In another JIRA. will improve the alias. 



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)