[GitHub] [cloudstack-primate] davidjumani commented on a change in pull request #812: infocard: Adding support to redirect to publicip

[GitBox <gi...@apache.org>]

davidjumani commented on a change in pull request #812:
URL: https://github.com/apache/cloudstack-primate/pull/812#discussion_r508669557



##########
File path: src/components/view/InfoCard.vue
##########
@@ -308,7 +308,8 @@
               type="environment"
               @click="$message.success(`${$t('label.copied.clipboard')} : ${ ipaddress }`)"
               v-clipboard:copy="ipaddress" />
-            <span>{{ ipaddress }}</span>
+            <router-link v-if="resource.ipaddressid" :to="{ path: '/publicip/' + resource.ipaddressid }">{{ ipaddress }}</router-link>

Review comment:
       Don't think that'll be needed since only public IPs will have an id associated with it




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org